Update version of hiredis to be compatible with Ruby 2.2+

[AmarHV]

In reference to #61, this updates the hiredis to 0.6.0. dependency to be compatible with Ruby 2.2+ and stop the undefined symbol: rb_thread_select error.

[whoahbot]

Hi AmarHV,

Thank you for the pull request. I pulled this branch down locally, but have been seeing test failures that may or may not be unrelated.

Do the tests pass for you locally? If so, I'd be happy to merge this and push up a new version of the gem.

[AmarHV]

Hi,

On the current version, I couldn't run the tests because I got an error about rspec-core not being installed. I bumped the rspec version to 2.4.0, and the specs ran, but they got the same errors as what I am getting on my PR.

I'm not sure if this is an error with rspec, or just something that was already on the branch. It doesn't seem that my PR has introduced new errors.

Have you seen this before?

[whoahbot]

Can you gist the errors that you are getting so that I can compare? I haven't seen the errors I'm getting when running the specs before, but I haven't run them in some time.

[AmarHV]

https://gist.github.com/AmarHV/c0e4e875454a61fe2e25

[whoahbot]

I'm seeing the same failures that you are, and one other that may be unrelated.

I doubt that these failures are directly related to the patch you submitted, but they seem to be legit. I'll need to investigate further before I merge your PR and push up a new gem.

Thank you again for submitting a PR! It is greatly appreciated.

[AmarHV]

Okay, no problem, thanks for making the gem :)

On 8 Dec 2015, at 11:25 AM, Dan Herrera [email protected] wrote:

I'm seeing the same failures that you are, and one other that may be unrelated.

I doubt that these failures are directly related to the patch you submitted, but they seem to be legit. I'll need to investigate further before I merge your PR and push up a new gem.

Thank you again for submitting a PR! It is greatly appreciated.

—
Reply to this email directly or view it on GitHub #62 (comment).