You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Going forward, since Girder exports a Swagger spec it would be nice to ingest this and use it to generate an Angular REST API client for WholeTale/Girder. A prototype @api module has been hacked together, but ideally this is not something that we want to manually maintain over time if it can be generated.
Furthermore, some of these issues are with Girder's own built-in schemas, so I'm not quite sure what options we have at our disposal for handling that.
No model / return type specified for most built-in API calls (e.g. folder, item, group, etc)
none of these models were generated by default, since it appears to swagger-gen that they are not being used anywhere
Missing some body parameters for POST/PUT calls (e.g. chunk for file uploads)
Some fields say "String" but expect a JSON-stringified object - I know that this is because we send all parameters in the querystring, but none of this should be necessary
Minor schema issues:
Many model schemas are missing _accessLevel (e.g. tale._accessLevel)
tale.publishInfo appears to have the wrong schema (this should be an array, right?)
Open Questions:
what type/schema to put for String? My current hack generated a bunch of import { String } from './String'; at the top of each model class, which is obviously not correct
dataSet / DataSet are entirely different models with different schemas - can we possibly consolidate?
Manual changes necessary to generate initial (hacked) API client:
Going forward, since Girder exports a Swagger spec it would be nice to ingest this and use it to generate an Angular REST API client for WholeTale/Girder. A prototype
@api
module has been hacked together, but ideally this is not something that we want to manually maintain over time if it can be generated.Furthermore, some of these issues are with Girder's own built-in schemas, so I'm not quite sure what options we have at our disposal for handling that.
See https://github.com/whole-tale/ngx-dashboard/commits/master/src/app/api for history
Major schema issues:
chunk
for file uploads)Minor schema issues:
_accessLevel
(e.g.tale._accessLevel
)dataSet
schema missingoptionalrequired_modelType
tale.publishInfo
appears to have the wrong schema (this should be an array, right?)Open Questions:
import { String } from './String';
at the top of each model class, which is obviously not correctdataSet
/DataSet
are entirely different models with different schemas - can we possibly consolidate?Manual changes necessary to generate initial (hacked) API client:
describe
endpoint: whole-tale/girder@fc454cagirder_wholetale
plugin: 2628de3The text was updated successfully, but these errors were encountered: