Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose preview image if desired #206

Closed
whyboris opened this issue Jul 10, 2019 · 5 comments · Fixed by #238
Closed

Choose preview image if desired #206

whyboris opened this issue Jul 10, 2019 · 5 comments · Fixed by #238
Labels
2.0.0 Priority for v2.0.0 release feature request New features
Milestone

Comments

@whyboris
Copy link
Owner

It's not clear to me why anyone would want this option, but I had a user request it 🤷‍♂

It's technically feasible. For ease of UI we could have the app receive drag-drop events, and if the event happens over a particular thumbnail, we'll just swap in* the image.

* ffmpeg already can handle an image resize, so it shouldn't be too problematic 😅

@whyboris whyboris added this to the Ideas milestone Jul 10, 2019
@cal2195
Copy link
Collaborator

cal2195 commented Jul 10, 2019

Hmmm, my only issue here is that recreating the hub, you'll lose this information - currently you can delete the thumbnail "cache", and recreate it all without any consequences! 🤔

I wonder what the usecase is... A better idea might be to autodetect a file named video_cover.jpg or something along those lines next to the video.mp4 and use that instead - overcomes my above issue, and is scripting-friendly like my tag feature! (I don't recall if I've merged that yet or not...)

@cal2195
Copy link
Collaborator

cal2195 commented Jul 10, 2019

#178 This one! 😄

@whyboris
Copy link
Owner Author

This sounds like a good option as well, though it forces users to format things a certain way.

I would reach out to the user who requested this feature before developing - just to get a sense of why / when they would be interested in using it 👍

ps -- this is for the Ideas Milestone 👌 -- no sooner 😅

@whyboris whyboris added the feature request New features label Jul 13, 2019
@whyboris
Copy link
Owner Author

whyboris commented Aug 2, 2019

The gentleman who requested the feature initially emailed me recently expressing he's looking forward to the version 2 and was wondering if I'd thought about including the option to replace the main image. I asked if drag-and-drop is a decent-enough interface and he said that would be great.

Turns out ❤️ Angular ❤️ makes detecting drop events stupid easy: just add (drop)=someFunc(event) in your code and you're done.

So I'm going to include this feature in 2.0.0 😉

@whyboris whyboris added the 2.0.0 Priority for v2.0.0 release label Aug 2, 2019
@whyboris whyboris modified the milestones: Ideas, v2.0.0 Aug 2, 2019
@whyboris
Copy link
Owner Author

whyboris commented Aug 2, 2019

Solved with #238 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.0 Priority for v2.0.0 release feature request New features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants