Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add star rating on right of top ribbon #562

Open
whyboris opened this issue Oct 20, 2020 · 3 comments
Open

Add star rating on right of top ribbon #562

whyboris opened this issue Oct 20, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@whyboris
Copy link
Owner

Should be pretty easy. After having clicked a video, the folder path and file name show up on the "top ribbon". On the right side of the ribbon there is space for 5 stars. Would be the easiest way to rate videos ⭐ ⭐ ⭐ ⭐ ⭐

@whyboris
Copy link
Owner Author

Thank you @qqweng for the PR 🤝 #586

I'm wondering whether it's better to relegate the star rating to the bottom tray 🤔 or just have both options 😓

I'm unsure about the star-rating at the top:

  • what happens when scanning is happening and the donut progress bar is showing?
  • since we'll have the details tray - won't it be overkill to have the star rating in the top-right as well?
  • at the very least, we'll want a button to hide the star rating from the top ribbon then? 🤔

@qqweng -- let me know your thoughts on this 🤝

@RumaboyLotti
Copy link

Hey would like to take a gander at this for my first issue I am assuming it is still open but let me know if that changes

@whyboris
Copy link
Owner Author

@RumaboyLotti -- thank you for offering your support.

I've not thought about this issue in a while, and currently I'm working on house stuff (with intent to get back to VHA development this winter) 😅

Now that we have the "details" tab at the bottom - with the star-rating already present there -- maybe star rating at the top isn't even needed.

If we do put it at the top, this is a challenging feature to add (from the UI - user interface - perspective). I am unsure why I added good first issue 😅

From the technical side it seems pretty straightforward, but resolving the UI questions in the above comment takes some thought.

If you have ideas to address the UI issues - could you post a screenshot? (A simple screenshot of the app with MS Paint--or similar low-quality mock up--is enough).

If this is a feature you particularly want - please share a screenshot of how you think it could work; if you're just eager to try something out, please consider another Issue ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants