Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] speed up auto-tag generation #871

Open
whyboris opened this issue Oct 31, 2024 · 4 comments
Open

[FEATURE] speed up auto-tag generation #871

whyboris opened this issue Oct 31, 2024 · 4 comments
Labels
enhancement Improves existing features good first issue Good for newcomers

Comments

@whyboris
Copy link
Owner

whyboris commented Oct 31, 2024

Looks like JS for loop is far faster than forEach (see video)

The slowest part of the auto-tag generation process is already outsourced to a web worker but it's currently using forEach

We may be able to get 2x the speed with a simple for loop 🤞 🚀 🤞

@whyboris whyboris added enhancement Improves existing features good first issue Good for newcomers labels Oct 31, 2024
@riddhi-b
Copy link

riddhi-b commented Nov 7, 2024

Hi! can i claim this issue?

@whyboris
Copy link
Owner Author

whyboris commented Nov 7, 2024

Hey @riddhi-b - you've claimed the issue ✅ 🤝

If you can, could you also perform some sort of a speed test to see if the change is worth it? 🙇‍♂️

@riddhi-b
Copy link

@whyboris Thanks! Sure I will try, is there a specific tool or anything you like to use to perform speed checks or are you ok with me using anything I can find?

@whyboris
Copy link
Owner Author

whyboris commented Dec 4, 2024

@riddhi-b - I suspect console.time() is the easiest, though feel free to use whatever you'd like 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing features good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants