Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint script missing #8

Open
anegg0 opened this issue Nov 1, 2022 · 4 comments
Open

Lint script missing #8

anegg0 opened this issue Nov 1, 2022 · 4 comments

Comments

@anegg0
Copy link

anegg0 commented Nov 1, 2022

Hi @wighawag, and thank you for what you do, I can't tell you how much I use your work.

yarn lint returns error Command "lint" not found.
I couldn't find the script in your package.json either.
I'm unsure if I'm using the repo correctly.

@wighawag
Copy link
Owner

wighawag commented Nov 2, 2022

Oh I forgot to update the readme, I removed linting, I realised I am not a fan of it, while I like prettier, lint was getting in my way too much. Feel happier without it

EDIT: I updated the readme now

@anegg0
Copy link
Author

anegg0 commented Nov 2, 2022

Not a problem, thank you for the update :)
I guess that closes this issue, won't do it myself since it's your repo!

@wighawag
Copy link
Owner

wighawag commented Nov 2, 2022

Yes true :D but happy to get feedback if you think lint is a good thing to have. could easily have a branch for example if needed

@anegg0
Copy link
Author

anegg0 commented Nov 2, 2022

I take care of the linting part on Emacs, so it's not really required on my end.
The only things I struggled with would probably fit in other issues:

  • package incompatibility with hardhat-toolbox (which I solved using yarn).
  • launching with npx hardhat which wipes the settings out (now I always make sure not to use it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants