line break, rename variable, small changes

wikimedia-gadgets · Nov 27, 2024 · a72ccc6 · a72ccc6
1 parent 9aa7ae4
commit a72ccc6
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/modules/submissions.js b/src/modules/submissions.js
@@ -2615,6 +2615,7 @@
 							const welcomeDraftCategories = [
 								'Category:Wikipedians who have received an AfC welcome message'
 							];
+
 							$.each( categories, ( _, cat ) => {
 								if ( welcomeDraftCategories.indexOf( cat ) !== -1 ) {
 									hasWelcomeDraftCat = true;
@@ -2626,11 +2627,11 @@
 						} );
 					}
 
-					$.when( shouldTeahouse, shouldWelcomeUser ).then( ( teahouse, welcomeDraft ) => {
-						let message;
+					$.when( shouldTeahouse, shouldWelcomeUser ).then( ( teahouse, welcome ) => {
+						let message = '';
 
-						if ( welcomeDraft ) {
-							message = AFCH.msg.get( 'welcomedraft-user' ) + '\n\n';
+						if ( welcome ) {
+							message += AFCH.msg.get( 'welcomedraft-user' ) + '\n\n';
 						}
 						if ( isDecline ) {
 							message += AFCH.msg.get( 'declined-submission', {