Merge "SummaryFormatterTest: Hard-code mocked class"

wikimedia · Feb 20, 2025 · 2667904 · 2667904
2 parents 4dbbabe + 8522758
commit 2667904
Showing 1 changed file with 3 additions and 13 deletions.
diff --git a/repo/tests/phpunit/includes/SummaryFormatterTest.php b/repo/tests/phpunit/includes/SummaryFormatterTest.php
@@ -3,6 +3,7 @@
 namespace Wikibase\Repo\Tests;
 
 use DataValues\DataValue;
+use MediaWiki\Title\Title;
 use MediaWikiLangTestCase;
 use ValueFormatters\ValueFormatter;
 use Wikibase\DataModel\Entity\BasicEntityIdParser;
@@ -440,8 +441,8 @@ public static function provideFormatSummary() {
 	 *
 	 * @dataProvider providerOnFormat
 	 */
-	public function testOnFormat( $type, $root, $pre, $auto, $post, $title, $local, $expected ) {
-		$itemTitle = $this->createMock( $title );
+	public function testOnFormat( $type, $root, $pre, $auto, $post, $local, $expected ) {
+		$itemTitle = $this->createMock( Title::class );
 		$itemTitle->expects( $this->once() )
 			->method( 'getNamespace' )
 			->willReturn(
@@ -466,87 +467,76 @@ public static function providerOnFormat() {
 				'item',
 				"wikibase-item",
 				false, '', false,
-				'\MediaWiki\Title\Title',
 				false,
 				null,
 			],
 			[
 				'item',
 				"wikibase-item",
 				false, '', false,
-				'\MediaWiki\Title\Title',
 				false,
 				null,
 			],
 			[
 				'item',
 				"wikibase-item",
 				true, 'wbeditentity', true,
-				'\MediaWiki\Title\Title',
 				false,
 				'!<span dir="auto"><span class="autocomment">.*?: </span></span>!',
 			],
 			[
 				'item',
 				"wikibase-item",
 				true, 'wbsetlabel-set:1|en', true,
-				'\MediaWiki\Title\Title',
 				false,
 				'!<span dir="auto"><span class="autocomment">.*?\[en\].*?: </span></span>!',
 			],
 			[
 				'item',
 				"wikibase-item",
 				false, 'wbsetlabel-set:1|<>', false,
-				'\MediaWiki\Title\Title',
 				false,
 				'!<span dir="auto"><span class="autocomment">.*?\[&#60;&#62;\].*?</span></span>!',
 			],
 			[
 				'item',
 				"wikibase-item",
 				false, 'wbsetlabel-set:1|&lt;&gt;', false,
-				'\MediaWiki\Title\Title',
 				false,
 				'!<span dir="auto"><span class="autocomment">.*?\[&#60;&#62;\].*?</span></span>!',
 			],
 			[
 				'item',
 				"wikibase-item",
 				false, 'wbsetlabel-set:1|&', false,
-				'\MediaWiki\Title\Title',
 				false,
 				'!<span dir="auto"><span class="autocomment">.*?\[&#38;\].*?</span></span>!',
 			],
 			[
 				'item',
 				"wikibase-item",
 				false, 'wbsetlabel-set:1|&amp;', false,
-				'\MediaWiki\Title\Title',
 				false,
 				'!<span dir="auto"><span class="autocomment">.*?\[&#38;\].*?</span></span>!',
 			],
 			[
 				'item',
 				"wikibase-item",
 				false, 'wbsetlabel-set:1|…', false,
-				'\MediaWiki\Title\Title',
 				false,
 				'!<span dir="auto"><span class="autocomment">.*?\[…\].*?</span></span>!',
 			],
 			[
 				'item',
 				"wikibase-item",
 				false, 'wbsetlabel-set:1|\'""\'', false,
-				'\MediaWiki\Title\Title',
 				false,
 				'!<span dir="auto"><span class="autocomment">.*?\[&#39;&#34;&#34;&#39;\].*?</span></span>!',
 			],
 			[
 				'item',
 				"wikibase-item",
 				false, 'wbsetlabel-set:1|&#039;&quot;&quot;&#039;', false,
-				'\MediaWiki\Title\Title',
 				false,
 				'!<span dir="auto"><span class="autocomment">.*?\[&#39;&#34;&#34;&#39;\].*?</span></span>!',
 			],