-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build_plugin script fails with Boost error #39
Comments
After more debugging, I was able to get closer to compiling using clang-6.0. I am still getting one error in compilation:
|
I was able to get around the error by changing:
to
This fix seems hacky and wrong, I would still appreciate your input on what you think the better way to solve this compiler issue would be. |
Hi @SwapnilPande, |
I'll try it later tonight and let you know how it goes. Don't worry about it being a mess, I get how the development process goes. I would love to help develop this package and get v2 stable, if you're okay with that. I've been debugging a couple of errors that I've encountered as I try to get this to run. |
That would be a huge help, now that I'm done with my degree its hard to find time to maintain this in my free time. I'm in the process of adding the rest of my thesis work which contains the NF1 model and new reward functions here, https://github.com/wil3/gymfc/tree/thesis-work There is also a PR here for a Docker container I'm just looking for some additional changes before it gets merged, #26 |
I tried replicating your environment, but I'm still getting the same error... Not really what the difference is now. |
Starting from an unmodified clone of the repo, can you provide me with the exact steps and output you get? |
Hi @SwapnilPande consider using this docker image or following the install instructions within it to get a correct environment set up, https://github.com/wil3/gymfc/blob/master/Dockerfile-demo. @MichaelManz and I have been testing this image and it does not produce the compiling errors you are referring too. |
@SwapnilPande I'm reviewing the code, I'm opening this back up because I noticed inconsistencies of true and TRUE being used in the code which should be fixed. I also reviewed the Gazebo source code which has instances of both being used. I still don't know why you get a build fail from it but it should be fixed. Please submit a PR for this change if you can. Thanks, |
Could you provide the output for running cmake and make? If you are still getting the error there is still an underlying problem with your environment we should try and identify. You also mentioned you are running in a docker container, could you share so we can compare to the one in this repo? That should be able to identify where the problem is. |
Sorry, had a busy week. To your first comment, do you want me to submit a PR to replace I was able to get everything running correctly using the following versions: With this configuration, I still did have to replace |
This is the output of cmake and make with
|
Hi @SwapnilPande, yes we should replace https://github.com/wil3/gymfc/blob/master/gymfc/envs/assets/gazebo/plugins/FlightControllerPlugin.cpp#L195 with 'true' since it is an inconsistency. Its the only case in the code using TRUE. It just so happens this will also fix your build as well. And yes we should also find root cause to make sure this won't affect your development in the future as our docker container does not through this error. Is that the full output of your cmake? It should output the CXX compiler among other things. I did notice you are using a newer version of DART (6.9.2) than we have tested with (6.7). Have you tried this DART version? My only guess at the moment is one of the header files is brining in a macro for TRUE in my environment and not yours. |
Sorry, I missed some lines when copying. Here is the full output. cmake:
make:
|
I actually originally tried with Dart version 6.7. However, I got build errors with Gazebo 10 when I use it. From my research into that issue, it appears that Gazebo 9+ introduced a fix for an issue that arose with Dart versions 6.9+, but that made it incompatible with older versions of Dart. I am not sure why Dart 6.7 works for you but not for me. There is likely some root cause for all of these issues. I have pushed my latest docker container with gymfc working to Docker Hub. You can pull it by running
Hopefully this will help with debugging. |
Do you happen to know the errors you got? |
Going through the installation process again with a fresh ubuntu 18.04 docker container (can be pulled using I get errors during installing gazebo: First error I get is during cmake:
I resolved this issue by running Next: I got cmake errors because of missing Ignition packages:
Not sure why these dependencies aren't being installed with the other gazebo dependencies. Once these dependencies are installed, I get an error during
This error has to do with Eigen datatypes. Have you seen this error? |
I have not seen those errors but there are a couple things I'm investigating for the build processes. Following the Gazebo install from source instructions, if you do a local install you must make sure to update your PATH environment variables, http://gazebosim.org/tutorials?tut=install_from_source&cat=install. If you do not then the cmake files will not be found. I only ran into this when building the GymFC plugins. I ported the demo docker file we have at the root of this repo to a travis config that may help installing the environment, I'm also in the processes of converting these to docker files. The other thing I noticed recently doing testing is if you install via |
The last issue I'm seeing is actually the same as #52. However, I just followed the steps exactly in the travis config file and I was able to get Gazebo to build successfully! I THINK the only difference between my installation and the installation steps in the travis config is the version of Gazebo. When switching to the gazebo 10 tag, I ran
while your script runs
There must be a breaking change between versions of Gazebo 10. If you'd like, I can submit a PR with a change to the README mentioning this detail. I can also add some tips that I found useful when I was running through the installation process. |
Nice! That would be concerning if a minor version can cause a break like that though. Could you do a diff or install the two side by side? Yea that would be helpful to update the README thanks, we should pin specific versions because the environment does not appear very flexible. |
@SwapnilPande would this issue be closed with PR #60 ? |
Yes it will! |
I am attempting build the plugin using the build_plugin.sh script. I get a Boost error:
I tried both of the suggested flags
-std=gnu++11
andfext-numeric-literals
. Neither of the flags change the error received. I also tried-DBOOST_MATH_DISABLE_FLOAT128
based on similar issues for other packages, but received the error:I was able to follow all of the other steps in the installation process without any problems, including building DART v6,7 and Gazebo 10 from source.
Some parameters:
Running in Docker container
Ubuntu 16.04
Boost version 1.58
g++/gcc version 6.50
The text was updated successfully, but these errors were encountered: