Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2349] Clean up ElytronXmlParser code. #1717

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[ELY-2349] Clean up ElytronXmlParser code. #1717

merged 1 commit into from
Dec 12, 2023

Conversation

ivassile
Copy link
Contributor

@Skyllarr Skyllarr added the +1 DV label Jun 23, 2022
@fjuma
Copy link
Contributor

fjuma commented Dec 12, 2023

@ivassile When you get a chance, please update this so it's against the 2.x branch. Thanks!

@ivassile ivassile requested a review from fjuma as a code owner December 12, 2023 21:06
@ivassile ivassile changed the base branch from 1.x to 2.x December 12, 2023 21:07
@ivassile
Copy link
Contributor Author

@ivassile When you get a chance, please update this so it's against the 2.x branch. Thanks!

Done

fjuma
fjuma approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ivassile!

@fjuma fjuma added the +1 FJ label Dec 12, 2023
@fjuma fjuma merged commit a257a18 into wildfly-security:2.x Dec 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjuma fjuma fjuma approved these changes

@Skyllarr Skyllarr Skyllarr approved these changes

Assignees
No one assigned
Labels
+1 DV +1 FJ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivassile @fjuma @Skyllarr