-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when manually building on windows, node-gyp generated .dll, but not .node #442
Comments
@lacymorrow help! |
I am not sure of the issue, are you able to build using an older version of
node?
|
node: v20 and node-gyp: v10 generates builds on linux (Ubuntu OS v22, Windowing system: x11). I tried with node v18 on windows 10 pro --msvs_version=2019, the same result. So is this something you can look into now or is this going to backlog? |
@WilixLead @lacymorrow you have any suggestions? |
I don't have the resources to debug these issues currently |
I'm running into this issue as well. I am using the following specs
Build makes it all the way to this file, generates the uiohook.dll but fails to create the iohook.node The build\iohook.vcxproj is called by the build/uiohook.sln These are the contents of that file
Poking around to see where in the code it determines to skip building the iohook.node file. |
Here is the verbose output of the build step from node-gyp
|
@ToothpickFactory, do you have any other ideas to fix this issue? We can try to work on this. |
@lacymorrow Is it possible for you to loop in someone from this community to check whether it's due to node-gyp configuration? If not, do you have anything I can try? I can try it myself and post an update here. |
I would check here, it looks like someone was able to get builds working for node 17-18 |
Also here: #387 |
Were any solutions found here? Have spent many hours trying to figure it out, but can't determine why the |
no, @Rydez |
Hi, I am currently at the same place that only .dll is generated, but .node. Any solutions on this, please and thanks! elease\uiohook.exp Done Building Project "C:\Users\thongphanhduangboudd\Documents\Electron\native\native\iohook\build\uiohook.sln" (default targets). Build succeeded. Time Elapsed 00:00:04.72 |
@tduangbo no solution till now |
Hey, got it to compile for Electron 28, and some of those PR for Electron 18-19 (DO NOT USE NODE-GYP 10) use 9.4 and 2019 build tools here is the build: PS C:\Users\thongphanhduangboudd\Documents\Electron\native\native\alternative\iohook> node build.js --upload=false --runtime electron --version 28.2.0 --abi 119 --verbose I used this fork: |
@tduangbo Awesome work! I will check this and get back to you in couple of days. |
line 174(in build.js): I changed from 2017 to 2019 |
@tduangbo thanks for the note. I will ping you if i need any help. |
node: v20
node-gyp: v10
msvs_version: 2019
`run: node-gyp rebuild --msvs_version=2019
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | win32 | x64
gyp info find Python using Python version 3.12.1 found at "C:\Users\12345\AppData\Local\Programs\Python\Python312\python.exe"
gyp info find VS using VS2022 (17.8.34511.84) found at:
gyp info find VS "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools"
gyp info find VS run with --verbose for detailed information
gyp info spawn C:\Users\12345\AppData\Local\Programs\Python\Python312\python.exe
gyp info spawn args [
gyp info spawn args 'C:\Users\12345\AppData\Roaming\npm\node_modules\node-gyp\gyp\gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'msvs',
gyp info spawn args '-I',
gyp info spawn args 'C:\Users\12345\Documents\GitHub\new-iohook\build\config.gypi',
gyp info spawn args '-I',
gyp info spawn args 'C:\Users\12345\AppData\Roaming\npm\node_modules\node-gyp\addon.gypi',
gyp info spawn args '-I',
gyp info spawn args 'C:\Users\12345\AppData\Local\node-gyp\Cache\20.11.0\include\node\common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=C:\Users\12345\AppData\Local\node-gyp\Cache\20.11.0',
gyp info spawn args '-Dnode_gyp_dir=C:\Users\12345\AppData\Roaming\npm\node_modules\node-gyp',
gyp info spawn args '-Dnode_lib_file=C:\Users\12345\AppData\Local\node-gyp\Cache\20.11.0\<(target_arch)\node.lib',
gyp info spawn args '-Dmodule_root_dir=C:\Users\12345\Documents\GitHub\new-iohook',
gyp info spawn args '-Dnode_engine=v8',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'C:\Users\12345\Documents\GitHub\new-iohook\build',
gyp info spawn args '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\MSBuild\Current\Bin\MSBuild.exe
gyp info spawn args [
gyp info spawn args 'build\uiohook.sln',
gyp info spawn args '/clp:Verbosity=minimal',
gyp info spawn args '/nologo',
gyp info spawn args '/p:Configuration=Release;Platform=x64'
gyp info spawn args ]
logger.c
input_helper.c
input_hook.c
post_event.c
system_properties.c
win_delay_load_hook.cc
Creating library C:\Users\12345\Documents\GitHub\new-iohook\build\Release\uiohook.lib and object C:\Users\12345\Do
cuments\GitHub\new-iohook\build\Release\uiohook.exp
Generating code
Previous IPDB not found, fall back to full compilation.
All 48 functions were compiled because no usable IPDB/IOBJ from previous compilation was found.
Finished generating code
uiohook.vcxproj -> C:\Users\12345\Documents\GitHub\new-iohook\build\Release\uiohook.dll
gyp info ok`
The text was updated successfully, but these errors were encountered: