Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle teams without a nickname #8

Open
will-hou opened this issue Apr 8, 2022 · 0 comments
Open

Handle teams without a nickname #8

will-hou opened this issue Apr 8, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@will-hou
Copy link
Owner

will-hou commented Apr 8, 2022

Currently, conversion will raise an exception if a team number is not recorded in the nicknames.json file. We should still allow conversion to occur even if there is a team without a nickname on record.

Teams without a nickname on record could be given a placeholder like "Unknown"

RStoCSV/convert.py

Line 108 in 0b740bb

team_nicks.append(nicknames[team])

@will-hou will-hou added the enhancement New feature or request label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@will-hou