Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache failed loads to prevent reoccurring error logs #16

Open
willnationsdev opened this issue Feb 7, 2018 · 4 comments
Open

Cache failed loads to prevent reoccurring error logs #16

willnationsdev opened this issue Feb 7, 2018 · 4 comments

Comments

@willnationsdev
Copy link
Owner

Currently, if you have ANY script in your project (or scene / resource for that matter) which fails to load, the Inheritance Dock will continue to attempt to load everything all over again every time the filesystem for the project is changed (so, if you save or move any file basically). If you are updating old code or have en mass rendered several files out of date (updated the engine version perhaps?), then a whole bunch of assets will become filled with errors all at once, and you'll get flooded with an error log for each resource, every time a change is made.

This can be fixed by keeping a dictionary of which resources failed to load, only attempting to load ones which have not yet failed to load, and finally, using the resource_saved signal in the 3.1 release, flagging which ones are ready for another load attempt.

@chanon
Copy link

chanon commented Mar 27, 2018

I would like to use your extension, but this is making every file save very slow.
I get a bunch of errors logged, but I have no idea which scenes are causing them, so I would like to suggest logging the scenes/resources that caused the errors too.

@willnationsdev
Copy link
Owner Author

Yeah, I agree, it can definitely stand to improve. The error report change is a good idea. I'll try to get these changes done when I can, but it may be a little while. Thanks for the feedback!

@willnationsdev
Copy link
Owner Author

willnationsdev commented Mar 28, 2018

I can go ahead and modify the error report sooner rather than later, but the rest of it will have to wait for 3.1 unfortunately.

Edit: actually, I'll have to check and see whether my resource_saved signal was cherry-picked into a 3.0.x build.

Edit: lol, nope. Still hasn't even been integrated into the master branch.

@willnationsdev
Copy link
Owner Author

Also, fyi, I'm working on some engine changes that should allow me to offload a lot of these cache-updates and inheritance checking to the C++ code which will also speed up the plugin's dock-reloads immensely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants