Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HA 2025 pymodbus 3.7.4 breaking change #1172

Closed
PatrikTrestik opened this issue Dec 19, 2024 · 5 comments
Closed

HA 2025 pymodbus 3.7.4 breaking change #1172

PatrikTrestik opened this issue Dec 19, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@PatrikTrestik
Copy link
Contributor

Description

In dev version of HA there is pymodbus upgreaded to version 3.7.4 (might be gigher).

There is breaking change referencing AsciiFramer.

Fix should be prepared and tested in advance before HA 2025 release.

Suggested Solution

Upgrade pymodbus to 3.7.4 in this integration.

Alternatives

No response

Additional Context

No response
@PatrikTrestik PatrikTrestik added the enhancement New feature or request label Dec 19, 2024
@wills106
Copy link
Owner

I was aware of the change from #1113 but wasn't sure why that install kept pulling down 3.7.4 instead of 3.6.9 which HA is meant to be pinned at.
Will work on supporting 3.7.4 soon.

@wills106 wills106 mentioned this issue Dec 23, 2024
Closed
@wills106
Copy link
Owner

Just released 2025.01.0b1 for anyone trying out HA 2025.1.0b

@wills106
Copy link
Owner

Just released 2025.01.0b2 with the fixes from 2024.12.2

This was referenced Jan 5, 2025
Closed
Closed
Closed
@wills106
Copy link
Owner

wills106 commented Jan 5, 2025

Closing as released 2025.01.2

@wills106 wills106 closed this as completed Jan 5, 2025
@Alfred99-HA
Copy link

Perfect fix in no time during weekend!
Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PatrikTrestik @wills106 @Alfred99-HA