Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should setting fix_g in flash_ebnm be allowed? #111

Open
pcarbo opened this issue Dec 18, 2023 · 0 comments
Open

Should setting fix_g in flash_ebnm be allowed? #111

pcarbo opened this issue Dec 18, 2023 · 0 comments

Comments

@pcarbo
Copy link
Collaborator

pcarbo commented Dec 18, 2023

You really shouldn't be messing with fix_g or g_init in flash_ebnm since flashier needs to be able to toggle fix_g. So maybe it would be better to not allow fix_g to be specified in flash_ebnm? (And throw an error if it is?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pcarbo