Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve use of log1p in the single-cell vignette #135

Open
pcarbo opened this issue Oct 30, 2024 · 0 comments
Open

Improve use of log1p in the single-cell vignette #135

pcarbo opened this issue Oct 30, 2024 · 0 comments

Comments

@pcarbo
Copy link
Collaborator

pcarbo commented Oct 30, 2024

@stephens999 wrote:

In the single cell vignette we use log1p directly, rather than something that preserves the sparsity of the matrix.
And we note the potential to do this in a smarter way.

I think we should change it so that we actually work with sparse matrices, so that the code will work even for
larger problems. In practice I think people will just copy the code without necessarily reading the note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant