Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System icon support #109

Open
Alchemi1963 opened this issue May 30, 2024 · 7 comments
Open

System icon support #109

Alchemi1963 opened this issue May 30, 2024 · 7 comments
Labels
enhancement New feature or request legacy Using legacy winapps

Comments

@Alchemi1963
Copy link
Contributor

I noticed that the install script favours system icons vs the present .svg files.
However, I didn't have the icons installed myself.

Eventually I edited the script to use the svg instead.
Maybe a check for the system icon can be added or let the user decide?

@oskardotglobal oskardotglobal added enhancement New feature or request legacy Using legacy winapps labels May 31, 2024
@Alchemi1963
Copy link
Contributor Author

Why was legacy added?
I am not using legacy winapps...

@jrevillard
Copy link

legacy means the bash script.... seems that a Go version is under preparation ;)

@oskardotglobal
Copy link
Member

*Rust, but yes

@oskardotglobal
Copy link
Member

Legacy refers to the shell script version, which as you saw is kind of hard to maintain

@NaniNoni
Copy link

Is the rewrite still happening? The rewrite branch hasn't been touched in quite a while (9 months).

@LDprg
Copy link
Member

LDprg commented Aug 22, 2024

@NaniNoni Yeah I have some unmerged changes on my fork, but I am currently very busy.

It is still beeing worked on. See #195

It will take some time until I get work on this again, but contributions are welcomed.

@NaniNoni
Copy link

NaniNoni commented Aug 22, 2024

No problem. I'm happy to help in any way that I can. I created FFI bindings to freerdp3 as that seems a better solution to using external processes everywhere: https://github.com/NaniNoni/freerdp-sys. I'm currently rewriting the winapps installer in Rust, as it's an independent component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request legacy Using legacy winapps
Projects
None yet
Development

No branches or pull requests

5 participants