Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use known versions of pip and setuptools #15

Closed
thclark opened this issue Sep 22, 2022 · 1 comment
Closed

Use known versions of pip and setuptools #15

thclark opened this issue Sep 22, 2022 · 1 comment

Comments

@thclark
Copy link
Contributor

thclark commented Sep 22, 2022

In our production containers for the services, we do something like:

FROM windpioneers/gdal-python:statutory-crow-gdal-2.4.1-python-3.8-slim as base

# Upgrade to latest pip and setuptools
RUN pip install --upgrade pip setuptools

But we shouldn't need to do this, and it sometimes causes problems because over subsequent releases the version of pip used can vary (it's not pinned). We expect updates to pip if we actually change the dev stack, but not from release to release of the end services (same story with poetry).

So, we should RUN pip install --upgrade pip setuptools when building the stack, which will allow us to remove that update command in order to stabilise production builds. If we need to update pip at some point, that should be done here at the stack level, not by the individual services.

@thclark
Copy link
Contributor Author

thclark commented Oct 28, 2024

Deprecating since #24 as the move to uv replaces pip and setuptools.

@thclark thclark closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant