Merge branch 'master' of https://github.com/windwalker-io/framework

windwalker-io · Jan 8, 2024 · 3a1527c · 3a1527c
2 parents 4b3fd45 + ca7d9ce
commit 3a1527c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/Field/AbstractField.php b/src/Field/AbstractField.php
@@ -14,6 +14,7 @@
     ManageLabelTrait,
     ManageRenderTrait,
     ManageWrapperTrait};
+use Windwalker\Form\Attributes\Fieldset;
 use Windwalker\Form\Form;
 use Windwalker\Form\FormNormalizer;
 use Windwalker\Form\FormRegistry;
@@ -342,12 +343,16 @@ public function getFieldset(): ?string
     /**
      * Method to set property fieldset
      *
-     * @param   ?string  $fieldset
+     * @param  Fieldset|string|null  $fieldset
      *
      * @return  static  Return self to support chaining.
      */
-    public function setFieldset(?string $fieldset): static
+    public function setFieldset(Fieldset|string|null $fieldset): static
     {
+        if ($fieldset instanceof Fieldset) {
+            $fieldset = $fieldset->getName();
+        }
+
         $this->fieldset = $fieldset;
 
         return $this;

diff --git a/src/Form.php b/src/Form.php
@@ -152,14 +152,12 @@ public function addField(
         Fieldset|string|null $fieldset = null,
         string $namespace = ''
     ): AbstractField {
-        if ($fieldset) {
-            $fieldset = $this->fieldset($fieldset);
-        } else {
+        if ($fieldset === null) {
             $fieldset = $this->fieldset;
         }
 
-        if ($fieldset) {
-            $field->setFieldset($fieldset->getName());
+        if ($fieldset !== null) {
+            $field->setFieldset($fieldset);
         }
 
         if (!$namespace) {