Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The factor of value loss #2

Open
JIElite opened this issue Mar 9, 2018 · 0 comments
Open

The factor of value loss #2

JIElite opened this issue Mar 9, 2018 · 0 comments

Comments

@JIElite
Copy link

JIElite commented Mar 9, 2018

In worker.py, we need to sample experience by using local model and then backpropagate the gradients of total loss. The total loss is composed of loss_of_actor, loss_of_critic and entropy.

In line 132, you have already multiply 0.5 to value_loss_vb, but in line 152 you to that again. Does it mean the factor of critic loss in total loss is 0.25? Is it what you want to do?

Thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant