Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Trigger CheckRevocationList use case (WPB-3243) - cherrypick #2458

Merged
merged 7 commits into from
Feb 12, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Feb 6, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Cherry pick from the original PR:

https://github.com/wireapp/kalium/pull/2415

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Test Results

2 906 tests  +6   2 784 ✔️ +6   3m 9s ⏱️ +38s
   510 suites ±0      122 💤 ±0 
   510 files   ±0          0 ±0 

Results for commit 9acb89d. ± Comparison against base commit efb46f1.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 6, 2024

Datadog Report

All test runs ce6f2ef 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2070 62 5m 24.1s Link
kalium-jvm 0 0 0 2784 122 9m 7.05s Link

@ohassine ohassine requested review from a team, yamilmedina, alexandreferris, MohamadJaara, mchenani and saleniuk and removed request for a team February 6, 2024 15:11
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (efb46f1) 58.40% compared to head (9acb89d) 58.38%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2458      +/-   ##
=============================================
- Coverage      58.40%   58.38%   -0.02%     
  Complexity        21       21              
=============================================
  Files           1171     1171              
  Lines          45224    45296      +72     
  Branches        4256     4289      +33     
=============================================
+ Hits           26413    26446      +33     
- Misses         16891    16925      +34     
- Partials        1920     1925       +5     
Files Coverage Δ
...nc/receiver/conversation/MLSWelcomeEventHandler.kt 90.47% <92.85%> (+0.47%) ⬆️
...gic/data/conversation/MLSConversationRepository.kt 83.29% <80.00%> (-0.23%) ⬇️
...n/kotlin/com/wire/kalium/cryptography/MLSClient.kt 52.05% <10.52%> (-45.39%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb46f1...9acb89d. Read the comment docs.

@ohassine ohassine enabled auto-merge February 7, 2024 10:28
…cherry-pick-develop

# Conflicts:
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/MLSConversationRepository.kt
#	logic/src/commonTest/kotlin/com/wire/kalium/logic/data/conversation/MLSConversationRepositoryTest.kt
@ohassine ohassine added this pull request to the merge queue Feb 12, 2024
Merged via the queue into develop with commit 3152e1e Feb 12, 2024
17 checks passed
@ohassine ohassine deleted the trigger_crl_check-cherry-pick-develop branch February 12, 2024 15:26
augustocdias pushed a commit that referenced this pull request Feb 13, 2024
…2458)

* feat: Trigger CheckRevocationList use case (WPB-3243) (#2415)

Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: boris <[email protected]>

* chore: pass test

---------

Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: boris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants