Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backup): add more types - metadata assets (WPB-14589) #3128

Open
wants to merge 5 commits into
base: feat/support-other-message-types
Choose a base branch
from

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Nov 26, 2024

TaskWPB-14589 Cross Platform Backup: Library - Assets and mapping new data from and to the lib


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Test Results

3 313 tests  ±0   3 206 ✅ ±0   5m 20s ⏱️ +39s
  566 suites ±0     107 💤 ±0 
  566 files   ±0       0 ❌ ±0 

Results for commit 82fb240. ± Comparison against base commit 47cf9c3.

♻️ This comment has been updated with latest results.

@yamilmedina yamilmedina changed the title feat(backup): add more types - metadata assets feat(backup): add more types - metadata assets (WPB-10575) Nov 26, 2024
@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 26, 2024

Datadog Report

Branch report: feat/add-more-types-metadata-assets
Commit report: 8d2866b
Test service: kalium-jvm

✅ 0 Failed, 3206 Passed, 107 Skipped, 39.89s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.03%. Comparing base (47cf9c3) to head (82fb240).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           feat/support-other-message-types    #3128      +/-   ##
====================================================================
- Coverage                             54.03%   54.03%   -0.01%     
====================================================================
  Files                                  1246     1246              
  Lines                                 36152    36152              
  Branches                               3656     3656              
====================================================================
- Hits                                  19535    19533       -2     
- Misses                                15207    15209       +2     
  Partials                               1410     1410              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47cf9c3...82fb240. Read the comment docs.

Copy link

sonarcloud bot commented Nov 27, 2024

@yamilmedina yamilmedina changed the title feat(backup): add more types - metadata assets (WPB-10575) feat(backup): add more types - metadata assets (WPB-14589) Nov 27, 2024
@yamilmedina yamilmedina marked this pull request as ready for review November 27, 2024 16:06
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants