-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update federation flag when fetching server config [WPB-14728] 🍒 #3144
fix: update federation flag when fetching server config [WPB-14728] 🍒 #3144
Conversation
...c/src/commonMain/kotlin/com/wire/kalium/logic/configuration/server/ServerConfigRepository.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs some merge conflicts resolution for it, before merge
...ence/src/commonMain/kotlin/com/wire/kalium/persistence/daokaliumdb/ServerConfigurationDAO.kt
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Bencher Report
Click to view all benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3144 +/- ##
===========================================
+ Coverage 54.17% 54.19% +0.01%
===========================================
Files 1251 1251
Lines 36403 36458 +55
Branches 3680 3689 +9
===========================================
+ Hits 19723 19758 +35
- Misses 15261 15277 +16
- Partials 1419 1423 +4
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3232 Passed, 107 Skipped, 1m 7.24s Total Time |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
federation flag was not updated when updating api version
Solutions
update it
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.