Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run UI logic on the main thread [WPB-9458] 🍒 #3056

Merged
merged 2 commits into from
May 31, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 29, 2024

BugWPB-9458 [Android] crash in wire activity

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

wire activity crashes when clearing view model

Solutions

we suspect that it have to do with changes in

override fun onResume() {
super.onResume()
lifecycleScope.launch(Dispatchers.Default) {
lockCodeTimeManager.get().observeAppLock()
// Listen to one flow in a lifecycle-aware manner using flowWithLifecycle
.flowWithLifecycle(lifecycle, Lifecycle.State.STARTED)
.first().let {
if (it) {
withContext(Dispatchers.Main) {
startActivity(
Intent(this@WireActivity, AppLockActivity::class.java)
)
}
}
}
}
proximitySensorManager.registerListener()
}
so reverting the changes should do the trick

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels May 29, 2024
@AndroidBob
Copy link
Collaborator

Build 5086 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara enabled auto-merge May 29, 2024 15:48
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MohamadJaara MohamadJaara added this pull request to the merge queue May 31, 2024
Merged via the queue into develop with commit 387c67e May 31, 2024
10 of 11 checks passed
@MohamadJaara MohamadJaara deleted the fix/WPB-9458--cherry-pick branch May 31, 2024 09:39
@AndroidBob
Copy link
Collaborator

Build 5095 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants