Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make learn more links clickable for automation v2 [WPB-5888] #3064

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jun 3, 2024

TaskWPB-5888 [Android] Separate links from dialogs - enabling automated testing


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This is a next approach to fix this issue: https://wearezeta.atlassian.net/browse/WPB-5888

Issues

Previous fix, although looking fine on devices and layout inspector, was not working for automation, because it can't use testTags and it can't find inline content text composable.

Solutions

In this PR, link text composable is extracted out of the inline content of the main text - inline content only contains a placeholder box to position the link correctly inside the text and to get valid size and position of that link to create the proper link text composable. Inline content is still used to make it work for all locales, no matter if the link is inside the text or at the end or if it's LTR or RTL.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@AndroidBob
Copy link
Collaborator

Build 5117 failed.

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, mchenani and ohassine and removed request for a team June 3, 2024 12:07
@AndroidBob
Copy link
Collaborator

Build 5118 succeeded.

The build produced the following APK's:

@AndroidBob
Copy link
Collaborator

Build 5256 failed.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Built wire-android-staging-release-pr-3064.apk is available for download

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Built wire-android-dev-debug-pr-3064.apk is available for download

Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Built wire-android-staging-release-pr-3064.apk is available for download

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Built wire-android-dev-debug-pr-3064.apk is available for download

@AndroidBob
Copy link
Collaborator

Build 5269 succeeded.

The build produced the following APK's:

@saleniuk saleniuk enabled auto-merge June 7, 2024 14:34
@saleniuk saleniuk added this pull request to the merge queue Jun 14, 2024
Merged via the queue into develop with commit a573beb Jun 14, 2024
11 checks passed
@saleniuk saleniuk deleted the fix/links-clickable-for-automation-v2-dev branch June 14, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants