Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buffer in memory instead of file handle for decoder #481

Open
Denneisk opened this issue Oct 18, 2024 · 1 comment
Open

Use buffer in memory instead of file handle for decoder #481

Denneisk opened this issue Oct 18, 2024 · 1 comment

Comments

@Denneisk
Copy link
Member

AdvDupe2 uses a temporary file to store and process the dupe contents as a stream. This works, but adds unnecessary complexity by having to create a file on the actual file system, and can cause problems if there's an issue accessing that file.

Implementing the buffer using Lua might also improve speed.

@thegrb93
Copy link
Contributor

thegrb93 commented Oct 18, 2024

I think I already tested it with SF stringstream and the performance was about the same. Was many years ago tho so not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants