-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect image markdown causes loop and crash #6
Comments
Unfortunately I cannot reproduce this error neither in browser nor in mocha tests. I have also tried to do it manually, using your settings. I have the following questions:
|
If it helps, the original post (before being edited) is here https://steemd.com/tx/b426edca06f28e11ce376adc39b87f788fc5efa5 . Maybe it requires the multiple malformed images in a row to trigger the issue ? 1: From package.json the version is "steem-content-renderer": "^2.1.1" Thanks for the help, sorry for the delay answering |
The same guy that made a post with borked images last time, did it again this week slightly differently and it breaks my site again. Post is https://steemit.com/sgl/@lk666/sonic-groove-live-week-3-original-song-inside-my-soul I'm guessing this is the code doing it :
This error gets dumped to the console in an infinite loop until the tab crashes :
Update: The post was updated and now works without any issues or errors in console. Here is the diff, to stop the crashes and issues he simply removed the whole block of images - http://scribe.steemian.info/?url=https%3A%2F%2Fsteemit.com%2F%40lk666%2Fsonic-groove-live-week-3-original-song-inside-my-soul |
I've run into a strange issue that seems to be handled in condensor and steempeak, but not steem-content-renderer .
The bug is triggered when attempting to render a post containing this code
<img src="![Sacrifice The Truth Logo.jpg](https://cdn.steemitimages.com/DQmUjNstssuPJpjPDDWfRnw1x2tY6AWWKcajDMGpPLA5iJf/Sacrifice%20The%20Truth%20Logo.jpg)"/>
This triggers a repeating wave of errors in browser console that eventually terminates itself complaining
You may have an infinite update loop in a component render function
These are the render options used when this happens
The loop and error isn't triggered if doNotShowImages is set to true, but this obviously isn't an ideal solution.
The text was updated successfully, but these errors were encountered: