Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note non-existent files specified in RemoveFile table are skipped #248

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

riverar
Copy link
Contributor

@riverar riverar commented Dec 4, 2023

The contributor guide does not have guidance regarding the src/Docusaurus/... path. Let me know if this is the wrong place for these edits.

MSI faintly refers to this behavior in its RemoveFiles action docs (https://learn.microsoft.com/en-us/windows/win32/msi/removefiles-action):

Those files whose components are resolved to any active Action state (that is, not in the Off or Null state) are removed if the file exists in the specified directory.

Copy link

github-actions bot commented Dec 4, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@riverar
Copy link
Contributor Author

riverar commented Dec 4, 2023

I have read the CLA Document and I hereby sign the CLA

wixbot added a commit to wixtoolset/.github that referenced this pull request Dec 4, 2023
@barnson barnson enabled auto-merge (rebase) December 4, 2023 18:52
@barnson barnson merged commit eeacde0 into wixtoolset:master Dec 4, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@riverar riverar deleted the patch-1 branch December 4, 2023 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants