Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DirBrowseFlags to IisWebDirProperties #596

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bevanweiss
Copy link
Contributor

Adds in support for configuring IIS DirBrowseFlags to Web Directories.

Fixes wixtoolset/issues#170
Fixes wixtoolset/issues#2637
Fixes wixtoolset/issues#2917

@bevanweiss
Copy link
Contributor Author

I think it might be better to rename the Db column as a more generic 'Attributes' field, since this provides some additional bits for flags for future enhancement with other boolean settings (would have been useful if this was already in so I could have used some for these browse flags).

I think there is a test case for a 'bug' in here also (commented out).
<iis:WebDirProperties Id="TestCacheControlMaxAgeNull" CacheControlMaxAge="2147483648" />

will crash out database validation since the 2147483648 value == 0x80000000 the MSI_NULL_INTEGER...
Not sure on a good fix for it however.

  1. Perhaps just adding +1 / -1 in the compiler to avoid this specific value. or
  2. A compiler error that specifically disallows this value without the confusing error around DB validation.

Since this column addition will break the merge module back compatibility (as I understand), it should probably be coupled with some other changes to IIS schema also (ScriptTimeout I think was the other)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant