Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement UseArtifactsOutput to mirror the .NET SDK #598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement UseArtifactsOutput to mirror the .NET SDK #598

wants to merge 1 commit into from

Conversation

brantburnett
Copy link

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@brantburnett
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

wixbot added a commit to wixtoolset/.github that referenced this pull request Jan 28, 2025
@wixbot
@brantburnett has signed the CLA in wixtoolset/wix#598
6267297
@brantburnett
Copy link
Author

@robmen I do have a couple of particular questions about this PR when you have a moment.

  1. Is the testing sufficient? What additional coverage would you like, more OutputTypes, more variations, or something included in WixE2E?
  2. I couldn't find documentation on current error codes, so I picked WIX9000 and WIX9001 for these new MSBuild-related errors as a placeholder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support .Net 8 preview 3 unified artifacts
1 participant
@brantburnett