Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] RBF modal feerate is still editable once replacement PSBT generated #1138

Open
jp1ac4 opened this issue Jun 25, 2024 · 2 comments · May be fixed by #1209
Open

[GUI] RBF modal feerate is still editable once replacement PSBT generated #1138

jp1ac4 opened this issue Jun 25, 2024 · 2 comments · May be fixed by #1209
Assignees
@pythcoiner
Labels
Glitch A small annoyance in the GUI that is not entirely a bug GUI gui related In discussion Not ready for implementation. It is still being discussed whether we should address this issue. Nice to have If it's not completed in time for the current version, it can be postponed
Milestone
v9 Liana - UI fix...

Comments

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Jun 25, 2024

After generating a fee-bumped PSBT, it's still possible to edit the feerate, but this won't do anything.

Either the feerate should become read-only in this case or editing the feerate should give the option to generate a new replacement PSBT.

image
@nondiremanuel nondiremanuel added GUI gui related Glitch A small annoyance in the GUI that is not entirely a bug In discussion Not ready for implementation. It is still being discussed whether we should address this issue. labels Jun 25, 2024
@nondiremanuel
Copy link
Collaborator

I wouldn't overcomplicate things here, so in my opinion making it read-only should be the way to go

@pythcoiner
Copy link
Collaborator

do we still have a way to bump (RBF) more the fee? if so i think read only is fine.

@pythcoiner pythcoiner linked a pull request Jul 19, 2024 that will close this issue
Open
@pythcoiner pythcoiner self-assigned this Jul 19, 2024
@nondiremanuel nondiremanuel moved this to In Review in Liana General Jul 19, 2024
@nondiremanuel nondiremanuel added this to the v7 - Liana milestone Jul 19, 2024
@nondiremanuel nondiremanuel added the Nice to have If it's not completed in time for the current version, it can be postponed label Jul 19, 2024
@nondiremanuel nondiremanuel modified the milestones: v7 - Liana, v8 - Liana Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pythcoiner pythcoiner

Labels
Glitch A small annoyance in the GUI that is not entirely a bug GUI gui related In discussion Not ready for implementation. It is still being discussed whether we should address this issue. Nice to have If it's not completed in time for the current version, it can be postponed
Projects
Liana General
Status: In Review
Milestone
v9 Liana - UI fixes and other
Development

Successfully merging a pull request may close this issue.

gui: disable replacement fee input if tx is already replaced pythcoiner/liana
3 participants
@nondiremanuel @jp1ac4 @pythcoiner