Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having to specify ssl:// prefix for SSL connections is confusing #1291

Open
darosior opened this issue Sep 7, 2024 · 4 comments
Open

Having to specify ssl:// prefix for SSL connections is confusing #1291

darosior opened this issue Sep 7, 2024 · 4 comments
Labels
Electrum Enhancement Improving an existing functionality GUI gui related UX

Comments

@darosior
Copy link
Member

darosior commented Sep 7, 2024

The connection to the Electrum server might fail just because you forgot to manually specify to Liana to not talk in cleartext to the server thanks to a manually-input prefix to the URL. In terms of UX we can do better.

We could:

  • Have a small text hint (possibly inside the text input itself) to not forget ssl://
  • Have a dropdown between SSL and cleartext right before the text input with default to SSL
  • Try to be smart and test both with and without SSL when not specified in the URL (could lead to silently downgrading from SSL to cleartext, so meh)
  • Something else?
@darosior darosior added GUI gui related Enhancement Improving an existing functionality UX labels Sep 7, 2024
@darosior darosior added this to the v7 - Liana milestone Sep 7, 2024
@pythcoiner
Copy link
Collaborator

pythcoiner commented Sep 7, 2024

i'd go for:

  • in every case we don't care the prefix, ping both at install step, if one ping works we update input field
  • if input field is not ssl, we display a warning

@pythcoiner
Copy link
Collaborator

note we already have a hint but only if the address is invalid:
image

@pythcoiner
Copy link
Collaborator

i'd go for:

  • in every case we don't care the prefix, ping both at install step, if one ping works we update input field
  • if input field is not ssl, we display a warning

i've implemented this approach in #1296

@nondiremanuel nondiremanuel moved this to Todo in Liana General Sep 9, 2024
@nondiremanuel nondiremanuel moved this from Todo to In Review in Liana General Sep 9, 2024
@darosior
Copy link
Member Author

At this point, this doesn't need to be in v7.

@darosior darosior removed this from the v7 - Liana milestone Sep 10, 2024
@nondiremanuel nondiremanuel added this to the v8 - Liana milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Electrum Enhancement Improving an existing functionality GUI gui related UX
Projects
Status: In Review
Development

No branches or pull requests

3 participants