[PHP Academy] - Challenge 1 by Fernando Alvarez #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernyettheplant
changed the title
marconi1992
reviewed
Sep 11, 2018
| $this->info('Getting Info to start to import'); | ||
| $paginationMetadata = $this->eventDataProvider->getPaginationMetadataByLocation($location); | ||
|
|
||
| for ($page = 1; $page <= $paginationMetadata->page_count; $page++) { |
There was a problem hiding this comment.
it's fine, we could improve this using a do while or even return an iterator from the data provider to handle the iteration over the pagination.
marconi1992
requested changes
Sep 11, 2018
| $lastPage = ceil($total/$size); | ||
| $items = $pageCursor->toArray(); | ||
|
|
||
| return response()->json([ |
There was a problem hiding this comment.
marconi1992
reviewed
Sep 11, 2018
| @@ -3,6 +3,7 @@ | |||
| namespace App\Jobs; | |||
|
|
|||
| use MongoDB\Client as MongoClient; | |||
| use App\Importer\Contracts\VenueDataProvider as IVenueDataProvider; | |||
There was a problem hiding this comment.
C# interface naming convention :baia-baia:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the First Challenge