Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional entry of length or number of octets in GRIB2_Template_ csv-files #219

Open
SibylleK opened this issue Sep 18, 2023 · 9 comments · Fixed by #290
Open

Additional entry of length or number of octets in GRIB2_Template_ csv-files #219

SibylleK opened this issue Sep 18, 2023 · 9 comments · Fixed by #290
Assignees

Comments

@SibylleK
Copy link
Contributor

Details

In GRIB2 Template definition files the octet number (from - to) for each entry in the GRIB section is given.
Most of the GRIB processing software packages need the length or number of octets for each entry, which has to be calculated from the specification of "OctetNo".

But with variables and repitition within some templates an automated calculation is sometimes not easy. (e.g. 37 + (ND-1)*4 + (NF-1)*4 -40 +(ND-1)*4 + (NF-1)*4)

Therefore, this is a proposal to add a column with the length of each entry in the GRIB2_Template files.

Requestor

Sibylle Krebber, @SibylleK

@shahramn
Copy link

A very good suggestion

@amilan17
Copy link
Member

amilan17 commented Sep 22, 2023

https://github.com/wmo-im/CCT/wiki/20.to.22.September.2023 notes:

  • Title_en, OctetNo, octetCount, Contents_en, Note_en, noteIDs, codeTable, flagTable, Status
  • there could be an impact on the software that is ingesting the machine-readable codes; 
  • the script to generate the TXT,CSV will need to be updated
  • template with a sample and the software can be updated for testing

@antoinemerle
Copy link
Contributor

@antoinemerle :
On roadmap purpose and planning on EUM side :

  • : need to check in the vocabulary manager what would be the impact : are we taking the data from the xml or note, how do we parse the xml in a way it is going to break or not our interfaces.
  • Estimate the cost of the impact on EUM side / implementation of this new colomn

e.g :
image

@sebvi
Copy link
Contributor

sebvi commented Nov 20, 2023

Are we implementing this? I don't see a branch created for it

@marijanacrepulja
Copy link
Contributor

I believe we agreed to address this after finalising FT2024-1.

@amilan17 amilan17 moved this to In discussion in GRIB2 Amendments Aug 22, 2024
@amilan17 amilan17 added this to the noTargetMilestone milestone Aug 22, 2024
@amilan17
Copy link
Member

https://github.com/wmo-im/tt-tdcf/wiki/2024.10.15.tt.tdcf notes:
@amilan17 will update master after merging in FT2024-2 branch

@amilan17
Copy link
Member

Do the machine-readable files also need to include OctetCount?

@sebvi
Copy link
Contributor

sebvi commented Nov 11, 2024

Octet counts are not needed on our side

EDIT: actually it is a useful validation if the count is present

@amilan17
Copy link
Member

amilan17 commented Nov 12, 2024

https://github.com/wmo-im/tt-tdcf/wiki/2024.11.12.tt.tdcf notes:

  • empty columns are created for all templates, needs checking
  • @antoinemerle can help with scripts to ensure that the TXT and XML output files do NOT include the OctetCount column
  • Sibylle it would be even better (eventually) if the octet can be calculated from the OctetCount but not necessary today
  • @antoinemerle new script to retroactively populate all octetCount columns

@github-project-automation github-project-automation bot moved this from In progress to Ready for FT approval procedure in GRIB2 Amendments Nov 28, 2024
@amilan17 amilan17 reopened this Nov 28, 2024
@github-project-automation github-project-automation bot moved this from Ready for FT approval procedure to In progress in GRIB2 Amendments Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
6 participants