Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce Source column in CSVs #141

Closed
2 tasks done
tomkralidis opened this issue May 31, 2024 · 3 comments · Fixed by #145
Closed
2 tasks done

introduce Source column in CSVs #141

tomkralidis opened this issue May 31, 2024 · 3 comments · Fixed by #145
Assignees
@tomkralidis

Comments

@tomkralidis
Copy link
Collaborator

tomkralidis commented May 31, 2024 •
edited
Loading

In similar fashion to the WCMP2 codelists (example), some terms/topics may be defined in an external codelist.

  • add a Source column to each CSV
  • update TTL generation to emit rdfs:isDefinedBy if Source is populated for a given topic / CSV row
@tomkralidis tomkralidis self-assigned this May 31, 2024
@tomkralidis tomkralidis added this to the FT2024-2 milestone Jun 3, 2024
tomkralidis added a commit that referenced this issue Jun 3, 2024
@tomkralidis
introduce Source column in CSVs (#141)
8462314
@tomkralidis tomkralidis mentioned this issue Jun 3, 2024
Merged
@amilan17
Copy link
Member

amilan17 commented Jun 3, 2024

  1. What is the background on this change?
  2. Should this source column indicate a URL or can it be free text?
  3. Do we also want the source to be published to the Codes Registry?

@tomkralidis
Copy link
Collaborator Author

  1. This change aligns with the setup for wcmp2-codelists example. Hydrology want to define some topics using WIGOS codes
  2. URL only
  3. Yes (PR introduce Source column in CSVs (#141)  #145 implements this update in the related Python script)

@amilan17
Copy link
Member

amilan17 commented Jun 3, 2024

https://github.com/wmo-im/tt-wismd/wiki/Meeting-2024-06-03 notes:
Tom presented the issue

tomkralidis added a commit that referenced this issue Jun 4, 2024
@tomkralidis
introduce Source column in CSVs (#141) (#145)
5f56ade 
* introduce Source column in CSVs (#141)

* update script

* address @antje-s comments
@amilan17 amilan17 removed this from the FT2024-2 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomkralidis tomkralidis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

introduce Source column in CSVs (#141) wmo-im/wis2-topic-hierarchy
2 participants
@tomkralidis @amilan17