Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce Source column in CSVs (#141) #145

Merged
merged 3 commits into from
Jun 4, 2024
Merged

introduce Source column in CSVs (#141) #145

merged 3 commits into from
Jun 4, 2024

Conversation

tomkralidis
Copy link
Collaborator

Fixes #141

@tomkralidis tomkralidis added this to the FT2024-2 milestone Jun 3, 2024
amilan17
amilan17 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review everything, but I approve of the decision to add source columns to all topics.

@tomkralidis tomkralidis mentioned this pull request Jun 3, 2024
Closed
2 tasks
antje-s
antje-s approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@antje-s antje-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two questions to be on the safe side...(see comments)

@tomkralidis tomkralidis merged commit 5f56ade into main Jun 4, 2024
1 check passed
@tomkralidis tomkralidis deleted the issue-141 branch June 4, 2024 11:07
@amilan17 amilan17 removed this from the FT2024-2 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antje-s antje-s antje-s approved these changes

@josusky josusky josusky approved these changes

@amilan17 amilan17 amilan17 approved these changes

@gaubert gaubert Awaiting requested review from gaubert

@solson-nws solson-nws Awaiting requested review from solson-nws

@davidpodeur davidpodeur Awaiting requested review from davidpodeur

@jsieland jsieland Awaiting requested review from jsieland

@Amienshxq Amienshxq Awaiting requested review from Amienshxq

@masato-f29 masato-f29 Awaiting requested review from masato-f29

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

introduce Source column in CSVs
4 participants
@tomkralidis @amilan17 @josusky @antje-s