provide data inline to WNM #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
force-pushed
the
wnm-inline
branch
from
1aa055e to
dbe855c
Compare
|
CI failure is intermittent. |
tomkralidis
changed the title
tomkralidis
force-pushed
the
wnm-inline
branch
from
dbe855c to
72853fa
Compare
maaikelimper
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
OK so, if I understand correctly there is a new requirement for WIS2-notifications to include the data inline when the filesize is less than 4096 bytes.
I note that the same logic should be added to pywis-pubsub and wis2box-api (or better the logic should be implemented in pywis-pubsub and all clients import the WIS2Notification function from there ...)
|
@maaikelimper yes. PR in pywis-pubsub. Can you implement for wis2box-api:1.0b5 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WNM, include data/metadata inline as per the specification (suggested at W2AT 2023-11-13).