Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix #35

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bug fix #35

wants to merge 5 commits into from

Conversation

david-i-berry
Copy link
Member

@david-i-berry david-i-berry commented Dec 6, 2024 •
edited
Loading

Fixes #27, #28, and #30

Test docker workflow updated so downloads repeatable without hash check failing.

(and thanks to Aissa @AissaGeek for spotting the issues/proposing solutions)

@david-i-berry
Addresses:
4474942 
- #32 (http 200 check)
- #30 (integrity field)
- #27 (hash function)

Fixes path issues in Dockerfile.
@david-i-berry
Alignment with recent PR to address #32.
1b0167c
@david-i-berry
Addresses:
95efd0c 
- #30 (integrity field)
- #27 (hash function)

Fixes path issues in Dockerfile.
@david-i-berry
Reversion of dockerfile, presvious commit causes issues in automated …
ae116a5 
…tests
@david-i-berry
tests updated so reproducible download.
da93174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maaikelimper maaikelimper Awaiting requested review from maaikelimper

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: 'hashlib.HASH' object is not callable in validate_data method
1 participant
@david-i-berry