chore: fix lint errors and housekeeping

wnfs-wg · Dec 20, 2023 · 0886d5a · 0886d5a
1 parent 518e2b8
commit 0886d5a
Show file tree

Hide file tree

Showing 11 changed files with 46 additions and 30 deletions.
diff --git a/examples/demo/package.json b/examples/demo/package.json
@@ -27,7 +27,11 @@
     "vite-plugin-wasm": "^3.3.0"
   },
   "eslintConfig": {
-    "extends": ["@fission-codes"],
-    "ignorePatterns": ["dist"]
+    "extends": [
+      "@fission-codes"
+    ],
+    "ignorePatterns": [
+      "dist"
+    ]
   }
 }
diff --git a/package.json b/package.json
@@ -2,7 +2,10 @@
   "name": "@wnfs-wg/nest-root",
   "version": "0.0.0",
   "private": true,
-  "workspaces": ["packages/*", "examples/*"],
+  "workspaces": [
+    "packages/*",
+    "examples/*"
+  ],
   "packageManager": "[email protected]",
   "engines": {
     "node": ">=18"
@@ -38,7 +41,11 @@
   },
   "prettier": "@fission-codes/eslint-config/prettier.config.js",
   "eslintConfig": {
-    "extends": ["@fission-codes"],
-    "ignorePatterns": ["docs"]
+    "extends": [
+      "@fission-codes"
+    ],
+    "ignorePatterns": [
+      "docs"
+    ]
   }
 }
diff --git a/packages/nest/package.json b/packages/nest/package.json
@@ -57,7 +57,7 @@
   "types": "dist/src/index.d.ts",
   "browser": {
     "crypto": false,
-    "./dist/src/crypto.js": "./dist/src/crypto-browser.js"
+    "./src/crypto.js": "./src/crypto-browser.js"
   },
   "typesVersions": {
     "*": {
@@ -75,7 +75,7 @@
   },
   "files": ["src", "dist/src/*.d.ts", "dist/src/*.d.ts.map"],
   "scripts": {
-    "lint": "tsc --build && eslint . && prettier --check '**/*.{js,ts,yml,json}' --ignore-path ../../.gitignore",
+    "lint": "tsc --build && eslint . --quiet --ignore-pattern='readme.md' && prettier --check '**/*.{js,ts,yml,json}' --ignore-path ../../.gitignore",
     "build": "tsc --build",
     "test": "pnpm run test:node && pnpm run test:browser",
     "test:node": "mocha 'test/**/!(*.browser).test.ts' --bail --timeout 30000",

diff --git a/packages/nest/src/class.ts b/packages/nest/src/class.ts
@@ -1,5 +1,5 @@
 import type { Blockstore } from 'interface-blockstore'
-import type { PublicDirectory, PublicFile } from 'wnfs'
+import type { PrivateForest, PublicDirectory, PublicFile } from 'wnfs'
 
 import { CID } from 'multiformats/cid'
 import { AccessKey, PrivateDirectory, PrivateFile, PrivateNode } from 'wnfs'
@@ -305,7 +305,7 @@ export class FileSystem {
         const [accessKey, privateForest] = storeResult
 
         this.#rootTree = await this.#rootTree.replacePrivateForest(
-          privateForest,
+          privateForest as PrivateForest,
           [
             {
               path: Path.withPartition('private', n.path),
@@ -383,7 +383,7 @@ export class FileSystem {
   }
 
   /** @group Querying */
-  ls = this.listDirectory
+  ls = this.listDirectory // eslint-disable-line @typescript-eslint/unbound-method
 
   /** @group Querying */
   async read<D extends DataType, V = unknown>(
@@ -441,7 +441,7 @@ export class FileSystem {
   }
 
   /** @group Mutating */
-  cp = this.copy
+  cp = this.copy // eslint-disable-line @typescript-eslint/unbound-method
 
   /** @group Mutating */
   async createDirectory<P extends Partition>(
@@ -532,7 +532,7 @@ export class FileSystem {
   }
 
   /** @group Mutating */
-  mkdir = this.ensureDirectory
+  mkdir = this.ensureDirectory // eslint-disable-line @typescript-eslint/unbound-method
 
   /** @group Mutating */
   async move<From extends Partition, To extends Partition>(
@@ -557,7 +557,7 @@ export class FileSystem {
   }
 
   /** @group Mutating */
-  mv = this.move
+  mv = this.move // eslint-disable-line @typescript-eslint/unbound-method
 
   /** @group Mutating */
   async remove(
@@ -578,7 +578,7 @@ export class FileSystem {
   }
 
   /** @group Mutating */
-  rm = this.remove
+  rm = this.remove // eslint-disable-line @typescript-eslint/unbound-method
 
   /** @group Mutating */
   async rename<P extends Partition>(
@@ -730,10 +730,10 @@ export class FileSystem {
 
         const capsuleCID = await fileOrDir
           .store(Store.wnfs(this.#blockstore))
-          .then((a) => CID.decode(a))
+          .then((a) => CID.decode(a as Uint8Array))
         const contentCID =
           node.isFile() === true
-            ? CID.decode(node.asFile().contentCid())
+            ? CID.decode(node.asFile().contentCid() as Uint8Array)
             : capsuleCID
 
         return {

diff --git a/packages/nest/src/data.ts b/packages/nest/src/data.ts
@@ -56,7 +56,7 @@ export function dataToBytes(dataType: DataType, data: any): Uint8Array {
     }
 
     case 'utf8': {
-      return new TextEncoder().encode(data)
+      return new TextEncoder().encode(data as string)
     }
   }
 }
diff --git a/packages/nest/src/queries.ts b/packages/nest/src/queries.ts
@@ -109,7 +109,10 @@ export const publicRead = (options?: { offset: number; length: number }) => {
       .publicRoot()
       .read(params.pathSegments, Store.wnfs(params.blockstore))
 
-    return await publicReadFromCID(CID.decode(result), options)(params)
+    return await publicReadFromCID(
+      CID.decode(result as Uint8Array),
+      options
+    )(params)
   }
 }
 

diff --git a/packages/nest/src/references.ts b/packages/nest/src/references.ts
@@ -40,7 +40,7 @@ export async function capsuleCID(
     ? undefined
     : CID.decode(
         maybeNode.isFile()
-          ? await maybeNode.asFile().store(wnfsBlockstore)
-          : await maybeNode.asDir().store(wnfsBlockstore)
+          ? ((await maybeNode.asFile().store(wnfsBlockstore)) as Uint8Array)
+          : ((await maybeNode.asDir().store(wnfsBlockstore)) as Uint8Array)
       )
 }
diff --git a/packages/nest/src/root-tree/basic.ts b/packages/nest/src/root-tree/basic.ts
@@ -258,15 +258,15 @@ export class BasicRootTree implements RootTree {
     const links = [
       {
         Name: RootBranch.Exchange,
-        Hash: CID.decode(exchangeRoot),
+        Hash: CID.decode(exchangeRoot as Uint8Array),
       },
       {
         Name: RootBranch.Private,
-        Hash: CID.decode(privateForest),
+        Hash: CID.decode(privateForest as Uint8Array),
       },
       {
         Name: RootBranch.Public,
-        Hash: CID.decode(publicRoot),
+        Hash: CID.decode(publicRoot as Uint8Array),
       },
       {
         Name: RootBranch.Unix,

diff --git a/packages/nest/src/transaction.ts b/packages/nest/src/transaction.ts
@@ -234,7 +234,7 @@ export class TransactionContext {
   }
 
   /** @group Querying */
-  ls = this.listDirectory
+  ls = this.listDirectory // eslint-disable-line @typescript-eslint/unbound-method
 
   /** @group Querying */
   async read<D extends DataType, V = unknown>(
@@ -331,7 +331,7 @@ export class TransactionContext {
   }
 
   /** @group Mutating */
-  cp = this.copy
+  cp = this.copy // eslint-disable-line @typescript-eslint/unbound-method
 
   /** @group Mutating */
   async createDirectory(
@@ -389,7 +389,7 @@ export class TransactionContext {
   }
 
   /** @group Mutating */
-  mkdir = this.ensureDirectory
+  mkdir = this.ensureDirectory // eslint-disable-line @typescript-eslint/unbound-method
 
   /** @group Mutating */
   async move(
@@ -410,7 +410,7 @@ export class TransactionContext {
   }
 
   /** @group Mutating */
-  mv = this.move
+  mv = this.move // eslint-disable-line @typescript-eslint/unbound-method
 
   /** @group Mutating */
   async remove(
@@ -440,7 +440,7 @@ export class TransactionContext {
   }
 
   /** @group Mutating */
-  rm = this.remove
+  rm = this.remove // eslint-disable-line @typescript-eslint/unbound-method
 
   /** @group Mutating */
   async rename(

diff --git a/packages/nest/test/helpers/index.ts b/packages/nest/test/helpers/index.ts
@@ -87,7 +87,9 @@ export async function assertUnixFsFile(
     `${unixRoot.toString()}${pathString}`,
     opts.blockstore
   )
-  const unixBytes = Uint8Arrays.concat(await all(entry.content()))
+
+  const byteArrays: Uint8Array[] = await all(entry.content())
+  const unixBytes = Uint8Arrays.concat(byteArrays)
 
   assert.equal(Uint8Arrays.equals(unixBytes, bytes), true)
 }

diff --git a/packages/nest/tsconfig.json b/packages/nest/tsconfig.json
@@ -1,9 +1,9 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "outDir": "dist",
     "module": "NodeNext",
     "moduleResolution": "NodeNext",
+    "outDir": "dist",
     "noUnusedLocals": false
   },
   "include": ["src", "test"],