Merge pull request #7038 from SparkiDev/heapmath_mp_add_d

Heapmath mp_add_d: fix for when a and c same pointer
wolfSSL · Dec 7, 2023 · 5caa71e · 5caa71e
2 parents 9d0bb4c + 226c631
commit 5caa71e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/wolfcrypt/src/integer.c b/wolfcrypt/src/integer.c
@@ -4425,9 +4425,6 @@ int mp_add_d (mp_int* a, mp_digit b, mp_int* c) /* //NOLINT(misc-no-recursion) *
   /* old number of used digits in c */
   oldused = c->used;
 
-  /* sign always positive */
-  c->sign = MP_ZPOS;
-
   /* source alias */
   tmpa    = a->dp;
 
@@ -4478,6 +4475,9 @@ int mp_add_d (mp_int* a, mp_digit b, mp_int* c) /* //NOLINT(misc-no-recursion) *
      ix       = 1;
   }
 
+  /* sign always positive */
+  c->sign = MP_ZPOS;
+
   /* now zero to oldused */
   while (ix++ < oldused) {
      *tmpc++ = 0;