Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WOLFSSL_SINGLE_THREADED cmake option does not affect SINGLE_THREADED compile macro #7609

Closed
michael5904 opened this issue Jun 2, 2024 · 2 comments · Fixed by #7611 or #7631
Closed

WOLFSSL_SINGLE_THREADED cmake option does not affect SINGLE_THREADED compile macro #7609

michael5904 opened this issue Jun 2, 2024 · 2 comments · Fixed by #7611 or #7631
Assignees
@lealem47

Comments

@michael5904
Copy link

Version

Latest

Description

Pretty much self explanitory
@kareem-wolfssl kareem-wolfssl self-assigned this Jun 3, 2024
@lealem47 lealem47 assigned lealem47 and unassigned kareem-wolfssl Jun 3, 2024
@lealem47 lealem47 mentioned this issue Jun 3, 2024
Merged
4 tasks
@lealem47 lealem47 linked a pull request Jun 3, 2024 that will close this issue
cmake: Define SINGLE_THREADED macro when option enabled #7611
Merged
4 tasks
@lealem47
Copy link
Contributor

lealem47 commented Jun 3, 2024

Hi @michael5904,

I've put up a fix that should address the problem. Thanks for reporting this issue and your interest in wolfSSL.

@michael5904
Copy link
Author

Ive also noticed WOLFSSL_SINGLE_THREADED is wrongly used as "WOLFSSL_SINGLETHREADED" in another instance in the file cmake/functions.cmake.

dgarske added a commit to dgarske/wolfssl that referenced this issue Jun 7, 2024
@dgarske
Fix for CMake single threaded. wolfSSL#7609 (comment)
fda8b4f
@dgarske dgarske mentioned this issue Jun 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lealem47 lealem47

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@michael5904 @kareem-wolfssl @lealem47