Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need php-8.4-swoole #35042

Open
smoser opened this issue Nov 23, 2024 · 0 comments
Open

need php-8.4-swoole #35042

smoser opened this issue Nov 23, 2024 · 0 comments

Comments

@smoser
Copy link
Member

smoser commented Nov 23, 2024

We need to add php-8.4-swoole as soon as v6.0.0 release is available https://github.com/swoole/swoole-src/releases.

#34683 and #34897 added php-8.4 modules for all the modules that existed in 8.3 with the exception of php-8.4-swoole.

Several changes would be needed to make the 5.1.5 version of swoole build with php 8.4. Upstream explicitly removed support from
the 5.1 branch swoole/swoole-src#5525 .

There is likely to be a v6.0.0 release of swoole with php-8.4 support very soon. The rc1 was made released 2024-11-20.
The php-8.1-swoole, php-8.2-swoole, php-8.3-swoole should get automatic PRs done, but not php-8.4-swoole as it does not exist.

Adding it after 6.0.0 has landed for php-8.3-swoole is as simple as :

$ sed -e 's,name: php-8.3,name: php-8.4,' -e 'epoch: .*,epoch: 0,' php-8.3-swoole.yaml  > php-8.4-swoole.yaml
$ git add php-8.4-swoole.yaml
$ git commit -m "add php-8.4-swoole"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant