Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECE] Fix payment method title for orders paid with ECE button #3469

Closed
Tracked by #3381
Mayisha opened this issue Sep 25, 2024 · 1 comment · Fixed by #3482
Closed
Tracked by #3381

[ECE] Fix payment method title for orders paid with ECE button #3469

Mayisha opened this issue Sep 25, 2024 · 1 comment · Fixed by #3482
Assignees
Labels
component: ECE Issues related to Express Checkout Element

Comments

@Mayisha
Copy link
Contributor

Mayisha commented Sep 25, 2024

The payment method title is set to Credit/Debit Card instead of Apple Pay or Google Pay when purchased via the express checkout button.

Steps to reproduce

  • Enable the ECE feature flag (return true from is_stripe_ece_enabled function or in your database add an option _wcstripe_feature_ece and set yes as the value).
  • Checkout to the branch of either Implement ECE for payment processing on block checkout page #3439 or Integrating ECE to shortcode checkout #3436 (checkout to develop if any of the mentioned PR is merged)
  • As a shopper add a product to your cart and go to the checkout page.
  • Complete the purchase with Google/Apple pay button.
  • Notice that on the order confirmation page, the payment method is Credit/Debit Card instead of Apple Pay or Google Pay.
370430056-cf76c96b-d7fb-47c4-8b37-0778d296ed4e
  • As an admin, go to the order edit page and notice that the payment method is Card.
Screenshot 2024-09-25 at 4 31 44 PM

Expected behavior

  • The payment method title should be Google Pay or Apple Pay similar to how it is set when paid with PRB buttons.
Screenshot 2024-09-25 at 4 31 32 PM
@james-allan
Copy link
Contributor

I fixed this issue on my Pay For Order PR #3440. In that PR I added a new helper to map the payment button type to a payment method title.

I'll take this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ECE Issues related to Express Checkout Element
Projects
None yet
2 participants