Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Windows/Amd64 image #187

Open
cduchenoy opened this issue Nov 29, 2024 · 4 comments
Open

[Feature] - Windows/Amd64 image #187

cduchenoy opened this issue Nov 29, 2024 · 4 comments

Comments

@cduchenoy
Copy link

Hi,

I would like to submit the following Dockerfile

in order to have a version of the plugin on Windows.

The Windows version has been in production for a month with several of our customers

But I don't know how to proceed because I understand that you don't have the Windows infrastructure to build the image

We have made the image available for Windows Server 2022 at dockerhub

@pat-s
Copy link
Contributor

pat-s commented Dec 15, 2024

I guess #15 is required first as otherwise we can't use buildx to build for windows/amd64? But didn't look into it in detail.

@cduchenoy
Copy link
Author

Hi,

Sorry for the late reply :(

You right to have a native plugin #15 must be resolved

But in the meantime, this Dockerfile now allows you to have a functional plugin on Windows.

If you do not want to build the image (or include this Dockerfile in source) could you reference the github https://github.com/GECO-IT/woodpecker-windows for people who would like to use Woodpecker on Windows OS?

/Cyril

@qwerty287
Copy link
Contributor

@cduchenoy sorry for not really coming back to you, but I think the problem is that nobody of us maintainers really uses windows and thus we can't really test this. Otherwise it would be great to have an image for windows of course. Maybe you can open a pull request with the dockerfile so we can check it out there?

@cduchenoy
Copy link
Author

We also use Linux exclusively but in each company we follow, we realize that there are tasks which can be simplified by CI automation but which require Windows.

So I think there is really a need to cover

Windows is a pain because it still isn't buildx compatible !

This Dockerfile was tested by @6543 cf woodpecker-ci/woodpecker#4381

For our part I think we could make an Windows 2022 VM available to you

We could also reference our git in the awesome Woodpecker doc ?

What do you think ?

I will open an PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants