[BE] Test 리팩터링(#788) (#789)

woowacourse-teams · Nov 28, 2024 · 6cf6859 · 6cf6859
2 parents a32324a + bc83263
commit 6cf6859
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 315 deletions.
diff --git a/backend/src/test/java/corea/matching/infrastructure/GithubReviewClientTest.java b/backend/src/test/java/corea/matching/infrastructure/GithubReviewClientTest.java
@@ -1,14 +1,14 @@
 package corea.matching.infrastructure;
 
+import config.ServiceTest;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.boot.test.context.SpringBootTest;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-@SpringBootTest
+@ServiceTest
 class GithubReviewClientTest {
 
     @Autowired

diff --git a/backend/src/test/java/corea/matching/infrastructure/PrivateGithubPullRequestClientTest.java b/backend/src/test/java/corea/matching/infrastructure/PrivateGithubPullRequestClientTest.java
@@ -1,16 +1,16 @@
 package corea.matching.infrastructure;
 
+import config.ServiceTest;
 import corea.matching.infrastructure.dto.GithubUserResponse;
 import corea.matching.infrastructure.dto.PullRequestResponse;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.boot.test.context.SpringBootTest;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-@SpringBootTest
+@ServiceTest
 @Disabled
 class PrivateGithubPullRequestClientTest {
 
@@ -29,7 +29,7 @@ void get_private_repository() {
 
     @Test
     @DisplayName("레포지토리가 없으면 null 을 반환한다.")
-    void get_null_if_not_exist_repository(){
+    void get_null_if_not_exist_repository() {
         String repositoryLink = "https://github.com/woowacourse-precourse/java-christmas-6";
         String username = "00kang";
         PullRequestResponse response = privateGithubPullRequestClient.getPullRequest(repositoryLink, username);

diff --git a/backend/src/test/java/corea/matching/strategy/DynamicSizeMatchingStrategyTest.java b/backend/src/test/java/corea/matching/strategy/DynamicSizeMatchingStrategyTest.java
@@ -1,5 +1,6 @@
 package corea.matching.strategy;
 
+import config.ServiceTest;
 import corea.fixture.MemberFixture;
 import corea.fixture.RoomFixture;
 import corea.matching.domain.Pair;
@@ -14,13 +15,12 @@
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.boot.test.context.SpringBootTest;
 
 import java.util.List;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-@SpringBootTest
+@ServiceTest
 class DynamicSizeMatchingStrategyTest {
 
     @Autowired

diff --git a/backend/src/test/java/corea/matching/strategy/ReviewerPreemptiveMatchingStrategyTest.java b/backend/src/test/java/corea/matching/strategy/ReviewerPreemptiveMatchingStrategyTest.java
@@ -1,5 +1,6 @@
 package corea.matching.strategy;
 
+import config.ServiceTest;
 import corea.exception.CoreaException;
 import corea.fixture.MemberFixture;
 import corea.fixture.RoomFixture;
@@ -15,16 +16,13 @@
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.boot.test.context.SpringBootTest;
 
 import java.util.List;
-import java.util.Map;
-import java.util.stream.Collectors;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
-@SpringBootTest
+@ServiceTest
 class ReviewerPreemptiveMatchingStrategyTest {
 
     @Autowired

diff --git a/backend/src/test/java/corea/review/infrastructure/GithubPullRequestCommentClientTest.java b/backend/src/test/java/corea/review/infrastructure/GithubPullRequestCommentClientTest.java
@@ -1,18 +1,18 @@
 package corea.review.infrastructure;
 
+import config.ServiceTest;
 import corea.review.dto.GithubPullRequestReview;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.boot.test.context.SpringBootTest;
 
 import java.util.List;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
 @Disabled
-@SpringBootTest
+@ServiceTest
 class GithubPullRequestCommentClientTest {
 
     @Autowired

diff --git a/backend/src/test/java/corea/review/infrastructure/GithubPullRequestReviewClientTest.java b/backend/src/test/java/corea/review/infrastructure/GithubPullRequestReviewClientTest.java
@@ -1,18 +1,18 @@
 package corea.review.infrastructure;
 
+import config.ServiceTest;
 import corea.review.dto.GithubPullRequestReview;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.boot.test.context.SpringBootTest;
 
 import java.util.List;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
 @Disabled
-@SpringBootTest
+@ServiceTest
 class GithubPullRequestReviewClientTest {
 
     @Autowired

diff --git a/backend/src/test/java/corea/review/infrastructure/GithubReviewProviderTest.java b/backend/src/test/java/corea/review/infrastructure/GithubReviewProviderTest.java
@@ -1,5 +1,6 @@
 package corea.review.infrastructure;
 
+import config.ServiceTest;
 import corea.exception.CoreaException;
 import corea.review.dto.GithubPullRequestReview;
 import corea.review.dto.GithubPullRequestReviewInfo;
@@ -10,13 +11,12 @@
 import org.junit.jupiter.params.provider.NullAndEmptySource;
 import org.junit.jupiter.params.provider.ValueSource;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.boot.test.context.SpringBootTest;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 @Disabled
-@SpringBootTest
+@ServiceTest
 class GithubReviewProviderTest {
 
     @Autowired

diff --git a/backend/src/test/java/corea/review/pullRequest/ReviewPullRequestTest.java b/backend/src/test/java/corea/review/pullRequest/ReviewPullRequestTest.java
@@ -1,5 +1,6 @@
 package corea.review.pullRequest;
 
+import config.ServiceTest;
 import corea.fixture.MemberFixture;
 import corea.fixture.RoomFixture;
 import corea.matching.domain.PullRequestInfo;
@@ -15,23 +16,16 @@
 import corea.review.service.ReviewService;
 import corea.room.domain.Room;
 import corea.room.repository.RoomRepository;
-import io.restassured.RestAssured;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.boot.test.context.SpringBootTest;
-import org.springframework.boot.test.web.server.LocalServerPort;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
+@ServiceTest
 class ReviewPullRequestTest {
 
-    @LocalServerPort
-    int port;
-
     @Autowired
     private MemberRepository memberRepository;
 
@@ -53,11 +47,6 @@ class ReviewPullRequestTest {
     @Autowired
     private MatchResultService matchResultService;
 
-    @BeforeEach
-    void setUp() {
-        RestAssured.port = port;
-    }
-
     @Disabled
     @Test
     @DisplayName("리뷰어가 리뷰를 작성했을 때, 해당 리뷰의 링크로 업데이트 한다.")