From fcc3ba0aedcdf275f2fd4e467343a6fea9bed75e Mon Sep 17 00:00:00 2001 From: gyungchan Jo Date: Fri, 15 Nov 2024 16:25:20 +0900 Subject: [PATCH 1/3] =?UTF-8?q?feat:=20=EA=B0=9C=EB=B0=9C=20=ED=94=BC?= =?UTF-8?q?=EB=93=9C=EB=B0=B1=20=ED=82=A4=EC=9B=8C=EB=93=9C=20=EC=B6=94?= =?UTF-8?q?=EA=B0=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../feedback/domain/FeedbackKeyword.java | 54 +++++++++++++++---- 1 file changed, 43 insertions(+), 11 deletions(-) diff --git a/backend/src/main/java/corea/feedback/domain/FeedbackKeyword.java b/backend/src/main/java/corea/feedback/domain/FeedbackKeyword.java index 1120e28a4..73100f6db 100644 --- a/backend/src/main/java/corea/feedback/domain/FeedbackKeyword.java +++ b/backend/src/main/java/corea/feedback/domain/FeedbackKeyword.java @@ -12,17 +12,49 @@ @Getter public enum FeedbackKeyword { - MAKE_CODE_FOR_THE_PURPOSE("방의 목적에 맞게 코드를 잘 작성했어요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), - EASY_TO_UNDERSTAND_THE_CODE("코드를 이해하기 쉬웠어요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), - RESPONSE_FAST("응답 속도가 빨랐어요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), - - MAKE_CODE_FOR_THE_LITTLE_PURPOSE("방의 목적에 놓친 부분이 있어요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), - NORMAL_TO_UNDERSTAND_THE_CODE("코드를 이해는 했어요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), - RESPONSE_NORMAL("응답 속도가 적당했어요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), - - NOT_MAKE_CODE_FOR_THE_PURPOSE("방의 목적에 맞게 코드를 작성하지 않았어요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), - HARD_TO_UNDERSTAND_THE_CODE("코드를 이해하기 어려웠어요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), - RESPONSE_SLOW("응답 속도가 느렸어요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_1("코드를 이해하기 쉬웠어요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_2("코드의 가독성이 뛰어나요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_3("코드가 일관성 있게 작성되어 있어요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_4("변수 이름이 명확하고 직관적이에요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_5("메서드 및 클래스 이름이 명확해요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_6("기능이 명확하게 잘 구현되어 있어요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_7("코드의 구조가 논리적이에요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_8("코드 재사용성이 높아요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_9("예외 처리가 잘 되어 있어 안정적이에요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_10("문서화가 잘 되어 있어요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_11("테스트가 잘 작성되어 있어요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_12("코드가 잘 최적화되어 성능이 좋아요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_13("다양한 에지 케이스를 고려한 코드에요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + POSITIVE_DEVELOP_FEEDBACK_14("응답 속도가 빨랐어요", Evaluation.POSITIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + + NORMAL_DEVELOP_FEEDBACK_1("코드가 다소 복잡하게 느껴져요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_2("가독성을 높이기 위한 리팩토링이 필요해요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_3("기능은 잘 작동하지만 코드가 길어요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_4("코드의 일부가 중복되어 있어요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_5("기능이 제한적이어서 확장성이 떨어져요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_6("테스트 케이스가 몇 개 더 필요해요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_7("예외 처리 부분이 부족해 보여요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_8("성능 개선이 필요한 부분이 있어요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_9("문서화가 부족한 부분이 있어요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_10("코드가 기본적인 구조는 갖추고 있어요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_11("코드의 일관성이 조금 부족한 것 같아요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_12("에러 메시지가 부족해요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NORMAL_DEVELOP_FEEDBACK_13("응답 속도가 적당했어요", Evaluation.NORMAL, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + + NEGATIVE_DEVELOP_FEEDBACK_1("코드를 이해하기 어려웠어요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_2("코드의 가독성이 떨어져요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_4("코드가 일관성 있게 작성되지 않았어요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_3("변수 이름이 불명확하고 직관적이지 않아요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_5("메서드 및 클래스 이름이 명확하지 않아요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_6("기능이 명확하게 구현되지 않았어요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_7("코드의 구조가 비논리적이에요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_8("코드 재사용성이 낮아요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_9("예외 처리가 부족해 불안정해요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_10("문서화가 부족해요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_11("테스트가 부족해요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_12("코드가 최적화되지 않아 성능이 떨어져요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_13("다양한 에지 케이스를 고려하지 않은 코드에요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), + NEGATIVE_DEVELOP_FEEDBACK_14("응답 속도가 느렸어요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), KIND("친절했어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), GOOD_AT_EXPLAINING("설명이 이해가 잘 되었어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), From 318bec14034270c31bf18e0d75f5e12072958746 Mon Sep 17 00:00:00 2001 From: gyungchan Jo Date: Fri, 15 Nov 2024 16:34:14 +0900 Subject: [PATCH 2/3] =?UTF-8?q?feat:=20=EC=86=8C=EC=85=9C=20=ED=94=BC?= =?UTF-8?q?=EB=93=9C=EB=B0=B1=20=ED=82=A4=EC=9B=8C=EB=93=9C=20=EC=B6=94?= =?UTF-8?q?=EA=B0=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../feedback/domain/FeedbackKeyword.java | 59 +++++++++++++++---- 1 file changed, 46 insertions(+), 13 deletions(-) diff --git a/backend/src/main/java/corea/feedback/domain/FeedbackKeyword.java b/backend/src/main/java/corea/feedback/domain/FeedbackKeyword.java index 73100f6db..33cafc4e6 100644 --- a/backend/src/main/java/corea/feedback/domain/FeedbackKeyword.java +++ b/backend/src/main/java/corea/feedback/domain/FeedbackKeyword.java @@ -56,19 +56,52 @@ public enum FeedbackKeyword { NEGATIVE_DEVELOP_FEEDBACK_13("다양한 에지 케이스를 고려하지 않은 코드에요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), NEGATIVE_DEVELOP_FEEDBACK_14("응답 속도가 느렸어요", Evaluation.NEGATIVE, KeywordType.DEVELOP_FEEDBACK_KEYWORD), - KIND("친절했어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), - GOOD_AT_EXPLAINING("설명이 이해가 잘 되었어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), - HELPFUL("매우 도움이 되었어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), - REVIEW_FAST("리뷰 속도가 빨랐어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), - - NORMAL_AT_EXPLAINING("설명이 이해가 잘 되지 않았어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), - NORMALFUL("도움이 되었어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), - REVIEW_NORMAL("리뷰 속도가 적당했어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), - - UNKIND("불친절했어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), - BAD_AT_EXPLAINING("설명이 부족해요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), - NOT_HELPFUL("도움이 되지 않았어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), - REVIEW_SLOW("리뷰 속도가 느렸어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_1("친절했어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_2("설명이 이해가 잘 되었어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_3("매우 도움이 되었어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_4("리뷰 속도가 빨랐어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_5("리뷰 내용이 매우 유익했어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_6("피드백이 구체적이었어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_7("상황을 잘 이해해주셨어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_8("질문에 잘 답변해주셨어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_9("전반적으로 긍정적인 경험이었어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_10("피드백이 명확했어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_11("유익한 조언을 주셨어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_12("리뷰가 체계적이었어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_13("긍정적인 태도를 유지해주셨어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_14("의사소통이 원활했어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + POSITIVE_SOCIAL_FEEDBACK_15("상황에 대한 이해도가 높으셨어요", Evaluation.POSITIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + + NORMAL_SOCIAL_FEEDBACK_1("설명이 이해가 잘 되지 않았어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_2("도움이 되었어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_3("리뷰 속도가 적당했어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_4("조금 더 구체적이면 좋겠어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_5("질문에 대한 답변이 조금 부족했어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_6("리뷰를 통해 배운 점이 있었어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_7("리뷰가 다소 길었어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_8("피드백이 유용했지만 개선이 필요해요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_9("전반적으로 괜찮았어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_10("리뷰 내용이 명확하지 않았어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_11("조금 더 친절한 말투였으면 좋겠어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_12("리뷰의 내용이 조금 부족했어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_13("도움이 필요할 것 같아요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NORMAL_SOCIAL_FEEDBACK_14("리뷰가 약간 혼란스러웠어요", Evaluation.NORMAL, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + + NEGATIVE_SOCIAL_FEEDBACK_1("불친절했어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_2("설명이 부족해요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_3("도움이 되지 않았어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_4("리뷰 속도가 느렸어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_5("리뷰 내용이 매우 유익하지 않았어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_6("피드백이 모호했어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_7("상황을 잘 이해하지 못하셨어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_8("질문에 대한 답변이 불충분했어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_9("전반적으로 부정적인 경험이었어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_10("피드백이 불명확했어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_11("유익한 조언이 없었어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_12("리뷰가 비체계적이었어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_13("부정적인 태도를 보였어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_14("의사소통이 원활하지 않았어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), + NEGATIVE_SOCIAL_FEEDBACK_15("상황에 대한 이해도가 낮으셨어요", Evaluation.NEGATIVE, KeywordType.SOCIAL_FEEDBACK_KEYWORD), ; private static final Map CLASSIFIER = Arrays.stream(FeedbackKeyword.values()) From 0711b509edfb69eba9aac74d78d3baeb072f7b20 Mon Sep 17 00:00:00 2001 From: gyungchan Jo Date: Fri, 15 Nov 2024 16:43:27 +0900 Subject: [PATCH 3/3] =?UTF-8?q?test:=20=ED=94=BC=EB=93=9C=EB=B0=B1=20?= =?UTF-8?q?=ED=82=A4=EC=9B=8C=EB=93=9C=EB=AA=85=20=EB=B3=80=EA=B2=BD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../main/java/corea/ContextInitializer.java | 4 ++-- .../domain/ReceivedFeedbacksTest.java | 22 +++++++++---------- .../DevelopFeedbackRepositoryTest.java | 2 +- .../SocialFeedbackRepositoryTest.java | 2 +- .../service/UserFeedbackServiceTest.java | 2 +- .../corea/fixture/DevelopFeedbackFixture.java | 2 +- .../corea/fixture/SocialFeedbackFixture.java | 2 +- .../member/service/ProfileServiceTest.java | 6 ++--- 8 files changed, 21 insertions(+), 21 deletions(-) diff --git a/backend/src/main/java/corea/ContextInitializer.java b/backend/src/main/java/corea/ContextInitializer.java index 74761a9d6..9625b6f4a 100644 --- a/backend/src/main/java/corea/ContextInitializer.java +++ b/backend/src/main/java/corea/ContextInitializer.java @@ -409,8 +409,8 @@ private void matchingAndReviewComplete(List participations, Room } private void reviewSocialAndDevelopFeedback(MatchResult matchResult) { - socialFeedbackRepository.save(new SocialFeedback(matchResult.getRoomId(), matchResult.getReviewee(), matchResult.getReviewer(), 5, List.of(KIND, GOOD_AT_EXPLAINING), "너무 맘에 드는 말투이고, 설명이 친절했어요! 기회가 된다면 한번 더 리뷰 받고 싶어요~")); - developFeedbackRepository.save(new DevelopFeedback(matchResult.getRoomId(), matchResult.getReviewer(), matchResult.getReviewee(), 5, List.of(EASY_TO_UNDERSTAND_THE_CODE, MAKE_CODE_FOR_THE_PURPOSE), "코드를 이해하기 쉬워 리뷰하기 편했어요!~", 3)); + socialFeedbackRepository.save(new SocialFeedback(matchResult.getRoomId(), matchResult.getReviewee(), matchResult.getReviewer(), 5, List.of(POSITIVE_SOCIAL_FEEDBACK_1, POSITIVE_SOCIAL_FEEDBACK_2), "너무 맘에 드는 말투이고, 설명이 친절했어요! 기회가 된다면 한번 더 리뷰 받고 싶어요~")); + developFeedbackRepository.save(new DevelopFeedback(matchResult.getRoomId(), matchResult.getReviewer(), matchResult.getReviewee(), 5, List.of(POSITIVE_DEVELOP_FEEDBACK_1, POSITIVE_DEVELOP_FEEDBACK_2), "코드를 이해하기 쉬워 리뷰하기 편했어요!~", 3)); matchResult.reviewComplete(); matchResult.reviewerCompleteFeedback(); matchResult.revieweeCompleteFeedback(); diff --git a/backend/src/test/java/corea/feedback/domain/ReceivedFeedbacksTest.java b/backend/src/test/java/corea/feedback/domain/ReceivedFeedbacksTest.java index 46bc8b739..f70311af9 100644 --- a/backend/src/test/java/corea/feedback/domain/ReceivedFeedbacksTest.java +++ b/backend/src/test/java/corea/feedback/domain/ReceivedFeedbacksTest.java @@ -13,30 +13,30 @@ class ReceivedFeedbacksTest { @DisplayName("가장 많이 받은 긍정적인 피드백을 알 수 있다.") void findTopFeedbackKeywords1() { List> developFeedbackKeywords = List.of( - List.of(FeedbackKeyword.KIND, FeedbackKeyword.HELPFUL, FeedbackKeyword.REVIEW_FAST), - List.of(FeedbackKeyword.KIND, FeedbackKeyword.HELPFUL, FeedbackKeyword.REVIEW_FAST), - List.of(FeedbackKeyword.KIND, FeedbackKeyword.HELPFUL), - List.of(FeedbackKeyword.KIND) + List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_3), + List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_3), + List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2), + List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1) ); List> socialFeedbackKeywords = List.of( - List.of(FeedbackKeyword.MAKE_CODE_FOR_THE_PURPOSE, FeedbackKeyword.EASY_TO_UNDERSTAND_THE_CODE), - List.of(FeedbackKeyword.RESPONSE_FAST) + List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_1, FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_2), + List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_3) ); ReceivedFeedbacks receivedFeedbacks = new ReceivedFeedbacks(developFeedbackKeywords, socialFeedbackKeywords); List result = receivedFeedbacks.findTopFeedbackKeywords(3); - assertThat(result).containsExactly("친절했어요", "매우 도움이 되었어요", "리뷰 속도가 빨랐어요"); + assertThat(result).containsExactly("코드를 이해하기 쉬웠어요", "코드의 가독성이 뛰어나요", "코드가 일관성 있게 작성되어 있어요"); } @Test @DisplayName("가장 많이 받은 긍정적인 피드백을 알 수 있다.") void findTopFeedbackKeywords2() { List> developFeedbackKeywords = List.of( - List.of(FeedbackKeyword.KIND) + List.of(FeedbackKeyword.NEGATIVE_DEVELOP_FEEDBACK_1) ); List> socialFeedbackKeywords = List.of( - List.of(FeedbackKeyword.RESPONSE_SLOW, FeedbackKeyword.HARD_TO_UNDERSTAND_THE_CODE) + List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_1) ); ReceivedFeedbacks receivedFeedbacks = new ReceivedFeedbacks(developFeedbackKeywords, socialFeedbackKeywords); @@ -49,10 +49,10 @@ void findTopFeedbackKeywords2() { @DisplayName("긍정적인 피드백이 없다면 아무런 피드백도 반환하지 않는다.") void findTopFeedbackKeywords3() { List> developFeedbackKeywords = List.of( - List.of(FeedbackKeyword.UNKIND, FeedbackKeyword.BAD_AT_EXPLAINING) + List.of(FeedbackKeyword.NEGATIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.NEGATIVE_DEVELOP_FEEDBACK_2) ); List> socialFeedbackKeywords = List.of( - List.of(FeedbackKeyword.NOT_MAKE_CODE_FOR_THE_PURPOSE, FeedbackKeyword.RESPONSE_SLOW) + List.of(FeedbackKeyword.NORMAL_SOCIAL_FEEDBACK_1, FeedbackKeyword.NEGATIVE_SOCIAL_FEEDBACK_2) ); ReceivedFeedbacks receivedFeedbacks = new ReceivedFeedbacks(developFeedbackKeywords, socialFeedbackKeywords); diff --git a/backend/src/test/java/corea/feedback/repository/DevelopFeedbackRepositoryTest.java b/backend/src/test/java/corea/feedback/repository/DevelopFeedbackRepositoryTest.java index b98565746..3f0cff56b 100644 --- a/backend/src/test/java/corea/feedback/repository/DevelopFeedbackRepositoryTest.java +++ b/backend/src/test/java/corea/feedback/repository/DevelopFeedbackRepositoryTest.java @@ -37,7 +37,7 @@ void findAllKeywordsByReceiverId() { Member deliver = memberRepository.save(MemberFixture.MEMBER_PORORO()); Member receiver = memberRepository.save(MemberFixture.MEMBER_MOVIN()); - List feedbackKeywords = List.of(FeedbackKeyword.MAKE_CODE_FOR_THE_PURPOSE, FeedbackKeyword.RESPONSE_FAST); + List feedbackKeywords = List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2); DevelopFeedback feedback = new DevelopFeedback(room.getId(), deliver, receiver, 3, feedbackKeywords, "", 3); developFeedbackRepository.save(feedback); diff --git a/backend/src/test/java/corea/feedback/repository/SocialFeedbackRepositoryTest.java b/backend/src/test/java/corea/feedback/repository/SocialFeedbackRepositoryTest.java index 00e8d2f0b..6fd024724 100644 --- a/backend/src/test/java/corea/feedback/repository/SocialFeedbackRepositoryTest.java +++ b/backend/src/test/java/corea/feedback/repository/SocialFeedbackRepositoryTest.java @@ -37,7 +37,7 @@ void findAllKeywordsByReceiverId() { Member deliver = memberRepository.save(MemberFixture.MEMBER_PORORO()); Member receiver = memberRepository.save(MemberFixture.MEMBER_MOVIN()); - List feedbackKeywords = List.of(FeedbackKeyword.KIND, FeedbackKeyword.HELPFUL); + List feedbackKeywords = List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_1, FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_2); SocialFeedback feedback = new SocialFeedback(room.getId(), deliver, receiver, 3, feedbackKeywords, ""); socialFeedbackRepository.save(feedback); diff --git a/backend/src/test/java/corea/feedback/service/UserFeedbackServiceTest.java b/backend/src/test/java/corea/feedback/service/UserFeedbackServiceTest.java index 5818509b0..daabe1906 100644 --- a/backend/src/test/java/corea/feedback/service/UserFeedbackServiceTest.java +++ b/backend/src/test/java/corea/feedback/service/UserFeedbackServiceTest.java @@ -196,7 +196,7 @@ void getReceivedFeedback2() { private void saveRevieweeToReviewer(long roomId, Member reviewee, Member reviewer) { socialFeedbackRepository.save( - new SocialFeedback(null, roomId, reviewer, reviewee, 4, List.of(FeedbackKeyword.REVIEW_FAST, FeedbackKeyword.KIND), "유용한 정보들이 많았어요") + new SocialFeedback(null, roomId, reviewer, reviewee, 4, List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_4, FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_1), "유용한 정보들이 많았어요") ); } diff --git a/backend/src/test/java/corea/fixture/DevelopFeedbackFixture.java b/backend/src/test/java/corea/fixture/DevelopFeedbackFixture.java index c0c148292..8fb7e9e6c 100644 --- a/backend/src/test/java/corea/fixture/DevelopFeedbackFixture.java +++ b/backend/src/test/java/corea/fixture/DevelopFeedbackFixture.java @@ -14,7 +14,7 @@ public static DevelopFeedback POSITIVE_FEEDBACK(long roomId, Member deliver, Mem deliver, receiver, 4, - List.of(FeedbackKeyword.HELPFUL, FeedbackKeyword.EASY_TO_UNDERSTAND_THE_CODE), + List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2), "코드가 좋았어요", 2 ); diff --git a/backend/src/test/java/corea/fixture/SocialFeedbackFixture.java b/backend/src/test/java/corea/fixture/SocialFeedbackFixture.java index eb21f13b6..071bd8cd6 100644 --- a/backend/src/test/java/corea/fixture/SocialFeedbackFixture.java +++ b/backend/src/test/java/corea/fixture/SocialFeedbackFixture.java @@ -14,7 +14,7 @@ public static SocialFeedback POSITIVE_FEEDBACK(long roomId, Member deliver, Memb deliver, receiver, 4, - List.of(FeedbackKeyword.HELPFUL, FeedbackKeyword.EASY_TO_UNDERSTAND_THE_CODE), + List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_3, FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_2), "코드가 좋았어요" ); } diff --git a/backend/src/test/java/corea/member/service/ProfileServiceTest.java b/backend/src/test/java/corea/member/service/ProfileServiceTest.java index 9649f5429..f1235807c 100644 --- a/backend/src/test/java/corea/member/service/ProfileServiceTest.java +++ b/backend/src/test/java/corea/member/service/ProfileServiceTest.java @@ -60,9 +60,9 @@ void find_with_username() { private List getFeedbackKeywords() { return List.of( - FeedbackKeyword.MAKE_CODE_FOR_THE_PURPOSE, - FeedbackKeyword.EASY_TO_UNDERSTAND_THE_CODE, - FeedbackKeyword.RESPONSE_FAST + FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1, + FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2, + FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_3 ); } }