Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALL] 작업 현황 디스코드 알림 yml 파일 개선 #123

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[ALL] 작업 현황 디스코드 알림 yml 파일 개선 #123

merged 1 commit into from
Jul 31, 2024

Conversation

hwinkr
Copy link
Contributor

@hwinkr hwinkr commented Jul 31, 2024

관련 이슈

작업 내용

  • 작업 현황 디스코드 알림 yml 파일을 개선했어요!
    • 머지 메시지 구조 수정
    • changes_requested, comment에만 알림이 가도록 변경
    • single comment에는 알림이 가지 않도록 변경

특이 사항

리뷰 요구사항 (선택)

빠른 머지 제발.

@hwinkr hwinkr added ⚙️ 환경설정 환경을 설정해요 :) (ノಠ益ಠ)ノ彡┻━┻ 나 솔직히 이거 하기 싫음 :( labels Jul 31, 2024
@hwinkr hwinkr added this to the 3차 데모데이 milestone Jul 31, 2024
@hwinkr hwinkr self-assigned this Jul 31, 2024
hw0603
hw0603 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@hw0603 hw0603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yml 개발자 해리.. 고생 많으셨습니다😀

seokmyungham
seokmyungham approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@seokmyungham seokmyungham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 눈부시네요.. (ﾉ◕ヮ◕)ﾉ*:･ﾟ✧

seunghye218
seunghye218 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@seunghye218 seunghye218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빛나는 해리... 빛해로 부르도록 하겠습니다

@hwinkr hwinkr merged commit 96a10b5 into develop Jul 31, 2024
14 checks passed
@Yoonkyoungme
Copy link
Contributor

저 아직 리뷰 안 남겼는데요?

@Largopie
Copy link
Contributor

저 아직 리뷰 안했는데요 ㅠㅠ

@Largopie Largopie deleted the chore/121-improve-discord-yml branch July 31, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokmyungham seokmyungham seokmyungham approved these changes

@seunghye218 seunghye218 seunghye218 approved these changes

@ikjo39 ikjo39 ikjo39 approved these changes

@hw0603 hw0603 hw0603 approved these changes

@ehBeak ehBeak Awaiting requested review from ehBeak ehBeak is a code owner

@Yoonkyoungme Yoonkyoungme Awaiting requested review from Yoonkyoungme Yoonkyoungme is a code owner

@Largopie Largopie Awaiting requested review from Largopie Largopie is a code owner

Assignees

@hwinkr hwinkr

Labels
(ノಠ益ಠ)ノ彡┻━┻ 나 솔직히 이거 하기 싫음 :( ⚙️ 환경설정 환경을 설정해요 :)
Projects
2024-momo
Status: Done
Milestone
3차 데모데이
Development

Successfully merging this pull request may close these issues.

[ALL] 디스코드 알림 yml 파일을 개선해요 :)
7 participants
@hwinkr @Yoonkyoungme @Largopie @hw0603 @ikjo39 @seunghye218 @seokmyungham