✨ separate home API and recipe description API #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
hyxrxn
reviewed
Sep 18, 2024
There was a problem hiding this comment.
레시피 목록 api와 레시피 상세 설명 api를 분리했습니다.
일단 기능 완성을 확인하고, swagger에 반영하기 위해 컨트롤러에 E2E 테스트 하나만 추가했습니다.
findRecipeData(List<Long> recipeIds) 에서는 더이상 카테고리와 재료가 필요하지 않아 RecipeDataResponse를 사용할 필요 없고, 쿼리문에서 join 또한 필요 없습니다. 하지만 아직 수정하지는 않은 상태입니다!
기능이 목표한대로 돌아가는 것을 우선순위로 삼았기 때문에...
참고해서 확인해주시면 감사하겠습니다~
hyxrxn
reviewed
Sep 20, 2024
|
tackyu
approved these changes
Sep 21, 2024
Comment on lines
119
to
120
| private List<RecipeHomeWithMineResponse> convertToRecipeHomeResponses( | ||
| UserInfo userInfo, |
There was a problem hiding this comment.
없어도 되는 메서드라 지워버렸습니닷...
레시피 아이디 기준으로 해서 하나로 묶을 필요가 없네요
Comment on lines
133
to
134
| private RecipeHomeWithMineResponse getMainRecipeResponse(UserInfo userInfo, List<RecipeHomeResponse> groupedResponses) { | ||
| RecipeHomeResponse firstResponse = groupedResponses.getFirst(); |
|
HaiSeong
approved these changes
Sep 22, 2024
| @@ -50,7 +52,7 @@ public class RecipeService { | |||
| private final CommentService commentService; | |||
| private final RecipeLikeService recipeLikeService; | |||
|
|
|||
| public List<MainRecipeResponse> readRecipes(UserInfo userInfo, PageRecipeRequest pageRecipeRequest) { | |||
| public List<RecipeHomeWithMineResponse> readRecipes(UserInfo userInfo, PageRecipeRequest pageRecipeRequest) { | |||
| Pageable pageable = getValidatedPageable(pageRecipeRequest.pageNumber(), pageRecipeRequest.pageSize()); | |||
There was a problem hiding this comment.
아토가 수정한 내용은 아니긴 합니다.
로직을 전체적으로 확인하다가 보니getValidatedPageable의 검증내용이 service가 아닌 controller 혹은 dto에 어울리는 내용인것 같아 리뷰를 남깁니다.
There was a problem hiding this comment.
열심히 봐달라고 요청하니 정말 열심히 봐주셨군요.
매우 동의하고 칭찬합니다. 💯
옮겨보았으니 확인 한 번 해주시죠!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #349