Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout: do an audit of the app to make sure we are consistent with the support of safe area insets #13792

Closed
designsimply opened this issue Apr 1, 2020 · 10 comments

Comments

@designsimply
Copy link
Contributor

While beta testing version 14.5 of the app, I noticed quite a few places where various parts of the layout don't extend all the way to the right of the screen when in landscape mode. Here is an example from the Themes screen:

IMG_3672 copy

Tested with WPiOS 14.5.0.1 TestFlight beta on iPhone 11 iOS 13.4.

In comparison, it looks much nicer on a smaller device such as an iPhone 6S probably because it doesn't trigger a splitscreen view at that size:

IMG_3595

Tested with WPiOS 14.5.0.1 TestFlight beta on iPhone 6S iOS 13.3.1.

I took several more screenshots for reference:

IMG_3660 IMG_3661 IMG_3662 IMG_3663 IMG_3664 IMG_3665 IMG_3666 IMG_3667 IMG_3668 IMG_3669 IMG_3670 IMG_3671 IMG_3672 IMG_3674 IMG_3675 IMG_3676 IMG_3677 IMG_3678 IMG_3679 IMG_3685 IMG_3686 IMG_3687 IMG_3688

Tested with WPiOS 14.5.0.1 TestFlight beta on iPhone 11 iOS 13.4.

(internal reference: p4a5px-2wF-p2#comment-10730, where we specifically discussed display problems in the Reader but also decided to prioritize making sure user-created content is properly displayed in the apps)

@bjtitus
Copy link
Contributor

bjtitus commented Apr 1, 2020

it looks much nicer on a smaller device such as an iPhone 6S probably because it doesn't trigger a splitscreen view at that size

Just wanted to point out that this is an issue with the notch on these devices.

Many of these should be cleaned up, but we should expect to have a bit of a gap in many cases where controls would be obscured. As an example, this screenshot of Settings matches pretty closely with what the native Notes applications does with cells.


IMG_1311

@frosty
Copy link
Contributor

frosty commented Apr 17, 2020

Thanks for the report, @designsimply! We should do an audit of the app to double check we're being consistent with the support of safe area insets. For now, I'm going to adjust this issue to low priority, due to low severity (visual issue) x medium impact (only notched devices affected).

@mindgraffiti
Copy link
Contributor

mindgraffiti commented Apr 20, 2020

I'm currently researching this issue. The landscape layouts aren't consistent between similar viewports. For example, the iPhone 11 (iOS 13.4) displays a splitscreen view, but the iPhone 11 Pro (iOS 13.4) shares the same viewport size and does not display splitscreen. Please note that I say viewport and not screen size, because the iPhone 11 Pro has a higher pixel density but the same physical size as an iPhone 11. Turns out the iPhone 11 Pro is slightly physically smaller than the 11. The iPhone 11 is 6.1" and the iPhone 11 Pro is 5.8" 🙃

iPhone 11, iOS 13.4.1

iPhone 11 Pro, iOS 13.4.1

@mindgraffiti
Copy link
Contributor

mindgraffiti commented Apr 20, 2020

For reference, check out the Human Interface Guidelines > Visual Design > Adaptivity and Layout page, Device Size Classes heading.

In looking at the Landscape Orientation column of the HIG page, any device that is listed as Regular width should display the two-column layout. Any device that is listed as Compact width should display the single-column layout.

It appears that any device with a physical size of 6 inches (~15 mm) or greater gets the two-column layout in Landscape orientation.

They include:

  • all iPads
  • any iPhone "Plus" models
  • any iPhone "Max" models
  • the iPhone XR and iPhone 11

All other devices are expected to keep compact mode (single-column layouts):

  • iPhone SE
  • iPhone 6, 7, 8, X, Xs, 11 Pro

@mindgraffiti mindgraffiti self-assigned this Apr 20, 2020
@frosty
Copy link
Contributor

frosty commented Apr 21, 2020

Just an addition to your device lists above, the XR and 11 have a regular width by default.

@mindgraffiti
Copy link
Contributor

Thanks @frosty! Edited ✔️

@mindgraffiti mindgraffiti removed their assignment Apr 28, 2020
@designsimply designsimply changed the title General layout issues in landscape mode Layout: do an audit of the app to make sure we are consistent with the support of safe area insets Apr 30, 2020
@designsimply
Copy link
Contributor Author

Moved this out of the Prioritized iOS list due to low priority and I updated the title to reflect the comment saying we should "do an audit of the app to double check we're being consistent with the support of safe area insets." 👍

@designsimply
Copy link
Contributor Author

designsimply commented Apr 30, 2020

I'd like to suggest we cover this case as part of the audit proposed in this issue:

@jkmassel jkmassel added UI User interface bugs and removed Layout labels Jul 3, 2024
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

@jkmassel
Copy link
Contributor

This was done a long time ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants