Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported BreakPoint in Rust #550

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Conversation

itsAdee
Copy link
Contributor

@itsAdee itsAdee commented Aug 29, 2023

Looked at the implementation in JavaScript and replicated the code in RUST by going through libadwaitadocument.Works fine on my machine , please check it yourself and let me know of any problem.Thanks

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the nitpick, it looks good!

src/Library/demos/Breakpoints/code.rs Outdated Show resolved Hide resolved
src/Library/demos/Breakpoints/code.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the one comment, this looks good to me

src/Library/demos/Breakpoints/code.rs Outdated Show resolved Hide resolved
@itsAdee
Copy link
Contributor Author

itsAdee commented Aug 30, 2023

Apart from the one comment, this looks good to me

Added the suggestion :)

@Hofer-Julian
Copy link
Contributor

Thanks!

@Hofer-Julian Hofer-Julian merged commit 3dd548d into workbenchdev:main Aug 30, 2023
1 check passed
@itsAdee itsAdee deleted the Breakpoint-Impl branch September 25, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants